Support Android x86 ASan build.

Support Android x86 ASan build.

R=inferno@chromium.org,thakis@chromium.org
BUG=514423
NOPRESUBMIT=true
NOTRY=true

Committed: https://crrev.com/acd65abca005ec9680d4dab36e6055f1add48396
Cr-Commit-Position: refs/heads/master@{#341829}

[Oliver Chang, 2015-07-31 16:51:18]

PTAL. We're scaling our fuzzing to Android on GCE and need x86 ASan builds for
that.

[aarya, 2015-07-31 16:55:49]

aarya@google.com changed reviewers:
+ eugenis@chromium.org, hans@chromium.org
- inferno@chromium.org

[Nico, 2015-07-31 16:56:54]

do you need to change any gn files? do you need to update package.py or does it
do the right thing already?

https://codereview.chromium.org/1263213002/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1263213002/diff/20001/build/common.gypi#newco...
build/common.gypi:4921: '-target i686-linux-androideabi',
why this change?

https://codereview.chromium.org/1263213002/diff/20001/tools/clang/scripts/upd...
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/1263213002/diff/20001/tools/clang/scripts/upd...
tools/clang/scripts/update.sh:713: # Do the same for x86
maybe a for loop over desired archs instead of copypasta?

[Oliver Chang, 2015-07-31 17:46:31]

thanks for the review.

package.py should do the right thing already and include the new asan runtime. 

made a corresponding change to compiler/BUILD.gn to change x86 -> i686.

https://codereview.chromium.org/1263213002/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1263213002/diff/20001/build/common.gypi#newco...
build/common.gypi:4921: '-target i686-linux-androideabi',
On 2015/07/31 16:56:54, Nico (hiding) wrote:
> why this change?

Clang doesn't seem to support "x86" as a target cpu string.

https://codereview.chromium.org/1263213002/diff/20001/tools/clang/scripts/upd...
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/1263213002/diff/20001/tools/clang/scripts/upd...
tools/clang/scripts/update.sh:713: # Do the same for x86
On 2015/07/31 16:56:54, Nico (hiding) wrote:
> maybe a for loop over desired archs instead of copypasta?

Done.

[eugenis, 2015-07-31 17:59:15]

On 2015/07/31 17:46:31, ochang wrote:
> thanks for the review.
> 
> package.py should do the right thing already and include the new asan runtime.

> 
> made a corresponding change to compiler/BUILD.gn to change x86 -> i686.
> 
> https://codereview.chromium.org/1263213002/diff/20001/build/common.gypi
> File build/common.gypi (right):
> 
>
https://codereview.chromium.org/1263213002/diff/20001/build/common.gypi#newco...
> build/common.gypi:4921: '-target i686-linux-androideabi',
> On 2015/07/31 16:56:54, Nico (hiding) wrote:
> > why this change?
> 
> Clang doesn't seem to support "x86" as a target cpu string.
> 
>
https://codereview.chromium.org/1263213002/diff/20001/tools/clang/scripts/upd...
> File tools/clang/scripts/update.sh (right):
> 
>
https://codereview.chromium.org/1263213002/diff/20001/tools/clang/scripts/upd...
> tools/clang/scripts/update.sh:713: # Do the same for x86
> On 2015/07/31 16:56:54, Nico (hiding) wrote:
> > maybe a for loop over desired archs instead of copypasta?
> 
> Done.

x86 clang toolchain in the NDK says that:
LLVM_TRIPLE := i686-none-linux-android

[eugenis, 2015-07-31 18:00:11]

On 2015/07/31 17:59:15, eugenis wrote:
> On 2015/07/31 17:46:31, ochang wrote:
> > thanks for the review.
> > 
> > package.py should do the right thing already and include the new asan
runtime.
> 
> > 
> > made a corresponding change to compiler/BUILD.gn to change x86 -> i686.
> > 
> > https://codereview.chromium.org/1263213002/diff/20001/build/common.gypi
> > File build/common.gypi (right):
> > 
> >
>
https://codereview.chromium.org/1263213002/diff/20001/build/common.gypi#newco...
> > build/common.gypi:4921: '-target i686-linux-androideabi',
> > On 2015/07/31 16:56:54, Nico (hiding) wrote:
> > > why this change?
> > 
> > Clang doesn't seem to support "x86" as a target cpu string.
> > 
> >
>
https://codereview.chromium.org/1263213002/diff/20001/tools/clang/scripts/upd...
> > File tools/clang/scripts/update.sh (right):
> > 
> >
>
https://codereview.chromium.org/1263213002/diff/20001/tools/clang/scripts/upd...
> > tools/clang/scripts/update.sh:713: # Do the same for x86
> > On 2015/07/31 16:56:54, Nico (hiding) wrote:
> > > maybe a for loop over desired archs instead of copypasta?
> > 
> > Done.
> 
> x86 clang toolchain in the NDK says that:
> LLVM_TRIPLE := i686-none-linux-android

No need to put "none" there, I'm just saying that the change is OK.

[Oliver Chang, 2015-08-04 16:22:17]

Nico, could you please take a look again? I believe I've addressed the comments.

[Nico, 2015-08-04 17:50:08]

lgtm

[Oliver Chang, 2015-08-04 18:26:40]

The CQ bit was checked by ochang@chromium.org

[commit-bot: I haz the power, 2015-08-04 18:27:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263213002/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263213002/30001

[commit-bot: I haz the power, 2015-08-04 18:37:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 18:37:40]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Oliver Chang, 2015-08-04 18:55:35]

The CQ bit was checked by ochang@chromium.org

[commit-bot: I haz the power, 2015-08-04 18:56:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263213002/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263213002/30001

[commit-bot: I haz the power, 2015-08-04 19:30:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 19:30:08]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Oliver Chang, 2015-08-05 00:04:09]

The CQ bit was checked by ochang@chromium.org

[commit-bot: I haz the power, 2015-08-05 00:05:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263213002/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263213002/30001

[commit-bot: I haz the power, 2015-08-05 00:08:07]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2015-08-05 00:09:18]

Patchset 3 (id:??) landed as
https://crrev.com/acd65abca005ec9680d4dab36e6055f1add48396
Cr-Commit-Position: refs/heads/master@{#341829}