Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1399)

Unified Diff: runtime/lib/string_base.dart

Issue 12632014: Allow String.fromCharCodes to work directly on a GrowableObjectArray. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/string.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/string_base.dart
diff --git a/runtime/lib/string_base.dart b/runtime/lib/string_base.dart
index 660538c0dc52bda44d70463b0d546f7b1f9bc3d8..b2d126bef5d2cc78388a47470f6b3c185727ff43 100644
--- a/runtime/lib/string_base.dart
+++ b/runtime/lib/string_base.dart
@@ -20,7 +20,7 @@ class _StringBase {
* [codePoints].
*/
static String createFromCharCodes(Iterable<int> charCodes) {
- if (charCodes is! _ObjectArray) {
+ if (charCodes is! _ObjectArray && charCodes is! _GrowableObjectArray) {
charCodes = new List<int>.from(charCodes, growable: false);
}
return _createFromCodePoints(charCodes);
« no previous file with comments | « runtime/lib/string.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698