Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 12632008: Add additional ignores to native_client for VS2010 (Closed)

Created:
7 years, 9 months ago by Will Harris
Modified:
7 years, 9 months ago
Reviewers:
noelallen1, bradn, Sam Clegg
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Visibility:
Public.

Description

Add additional ignores to native_client for VS2010 TEST=ran "git status" on Windows, saw the VS2010 files were gone BUG=none Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=10965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M .gitignore View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Will Harris
adding some missing .gitignores to NaCl
7 years, 9 months ago (2013-03-07 19:45:49 UTC) #1
noelallen1
Handing to Sam. We use the VC2010 test system to test the VC2010 plugin, so ...
7 years, 9 months ago (2013-03-07 20:09:58 UTC) #2
noelallen1
On 2013/03/07 20:09:58, noelallen1 wrote: > Handing to Sam. We use the VC2010 test system ...
7 years, 9 months ago (2013-03-07 20:10:56 UTC) #3
Will Harris
On 2013/03/07 20:10:56, noelallen1 wrote: > On 2013/03/07 20:09:58, noelallen1 wrote: > > Handing to ...
7 years, 9 months ago (2013-03-07 20:13:21 UTC) #4
Sam Clegg
On 2013/03/07 20:13:21, Will Harris wrote: > On 2013/03/07 20:10:56, noelallen1 wrote: > > On ...
7 years, 9 months ago (2013-03-07 21:21:27 UTC) #5
Will Harris
On 2013/03/07 21:21:27, Sam Clegg wrote: > I'm guessing that this is needed so that ...
7 years, 9 months ago (2013-03-07 22:24:05 UTC) #6
Will Harris
I'm told that CQ doesn't commit to native_client repos so if you are happy with ...
7 years, 9 months ago (2013-03-08 13:09:56 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 9 months ago (2013-03-11 16:23:38 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 9 months ago (2013-03-11 16:34:31 UTC) #9
bradn
lgtm
7 years, 9 months ago (2013-03-11 20:05:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/wfh@chromium.org/12632008/1
7 years, 9 months ago (2013-03-11 20:30:24 UTC) #11
commit-bot: I haz the power
7 years, 9 months ago (2013-03-11 22:46:34 UTC) #12
Message was sent while issue was closed.
Change committed as 10965

Powered by Google App Engine
This is Rietveld 408576698