Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: chrome/renderer/extensions/set_icon_natives.cc

Issue 12632004: Revert 186643 - Caused a 10% regression on SunSpider benchmark (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/set_icon_natives.cc
===================================================================
--- chrome/renderer/extensions/set_icon_natives.cc (revision 186747)
+++ chrome/renderer/extensions/set_icon_natives.cc (working copy)
@@ -24,11 +24,9 @@
namespace extensions {
SetIconNatives::SetIconNatives(Dispatcher* dispatcher,
- RequestSender* request_sender,
- ChromeV8Context* context)
- : ChromeV8Extension(dispatcher, context->v8_context()),
- request_sender_(request_sender),
- context_(context) {
+ RequestSender* request_sender)
+ : ChromeV8Extension(dispatcher),
+ request_sender_(request_sender) {
RouteFunction(
"SetIconCommon",
base::Bind(&SetIconNatives::SetIconCommon, base::Unretained(this)));
@@ -138,8 +136,7 @@
bool has_callback = args[3]->BooleanValue();
bool for_io_thread = args[4]->BooleanValue();
- request_sender_->StartRequest(context_,
- name,
+ request_sender_->StartRequest(name,
request_id,
has_callback,
for_io_thread,
« no previous file with comments | « chrome/renderer/extensions/set_icon_natives.h ('k') | chrome/renderer/extensions/sync_file_system_custom_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698