Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2765)

Unified Diff: chrome/renderer/resources/extensions/miscellaneous_bindings.js

Issue 12632004: Revert 186643 - Caused a 10% regression on SunSpider benchmark (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/miscellaneous_bindings.js
===================================================================
--- chrome/renderer/resources/extensions/miscellaneous_bindings.js (revision 186747)
+++ chrome/renderer/resources/extensions/miscellaneous_bindings.js (working copy)
@@ -8,10 +8,10 @@
// content scripts only.
require('json_schema');
+ require('event_bindings');
var json = require('json');
var lastError = require('lastError');
var miscNatives = requireNative('miscellaneous_bindings');
- var chrome = requireNative('chrome').GetChrome();
var CloseChannel = miscNatives.CloseChannel;
var PortAddRef = miscNatives.PortAddRef;
var PortRelease = miscNatives.PortRelease;
@@ -121,7 +121,7 @@
if (sourceExtensionId != targetExtensionId)
errorMsg += " for extension " + targetExtensionId;
errorMsg += ").";
- lastError.set(errorMsg, chrome);
+ lastError.set(errorMsg);
console.error("Could not send response: " + errorMsg);
}
@@ -233,14 +233,14 @@
if (connectionInvalid) {
var errorMsg =
"Could not establish connection. Receiving end does not exist.";
- lastError.set(errorMsg, chrome);
+ lastError.set(errorMsg);
console.error("Port error: " + errorMsg);
}
try {
port.onDisconnect.dispatch(port);
} finally {
port.destroy_();
- lastError.clear(chrome);
+ lastError.clear();
}
}
};

Powered by Google App Engine
This is Rietveld 408576698