Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: chrome/renderer/extensions/web_request_custom_bindings.cc

Issue 12632004: Revert 186643 - Caused a 10% regression on SunSpider benchmark (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/web_request_custom_bindings.h" 5 #include "chrome/renderer/extensions/web_request_custom_bindings.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "grit/renderer_resources.h" 10 #include "grit/renderer_resources.h"
11 #include "v8/include/v8.h" 11 #include "v8/include/v8.h"
12 12
13 namespace extensions { 13 namespace extensions {
14 14
15 WebRequestCustomBindings::WebRequestCustomBindings( 15 WebRequestCustomBindings::WebRequestCustomBindings()
16 Dispatcher* dispatcher, v8::Handle<v8::Context> v8_context) 16 : ChromeV8Extension(NULL) {
17 : ChromeV8Extension(dispatcher, v8_context) {
18 RouteStaticFunction("GetUniqueSubEventName", &GetUniqueSubEventName); 17 RouteStaticFunction("GetUniqueSubEventName", &GetUniqueSubEventName);
19 } 18 }
20 19
21 // Attach an event name to an object. 20 // Attach an event name to an object.
22 // static 21 // static
23 v8::Handle<v8::Value> WebRequestCustomBindings::GetUniqueSubEventName( 22 v8::Handle<v8::Value> WebRequestCustomBindings::GetUniqueSubEventName(
24 const v8::Arguments& args) { 23 const v8::Arguments& args) {
25 static int next_event_id = 0; 24 static int next_event_id = 0;
26 DCHECK(args.Length() == 1); 25 DCHECK(args.Length() == 1);
27 DCHECK(args[0]->IsString()); 26 DCHECK(args[0]->IsString());
28 std::string event_name(*v8::String::AsciiValue(args[0])); 27 std::string event_name(*v8::String::AsciiValue(args[0]));
29 std::string unique_event_name = 28 std::string unique_event_name =
30 event_name + "/" + base::IntToString(++next_event_id); 29 event_name + "/" + base::IntToString(++next_event_id);
31 return v8::String::New(unique_event_name.c_str()); 30 return v8::String::New(unique_event_name.c_str());
32 } 31 }
33 32
34 } // extensions 33 } // extensions
35 34
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/web_request_custom_bindings.h ('k') | chrome/renderer/extensions/webstore_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698