Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: chrome/renderer/extensions/sync_file_system_custom_bindings.cc

Issue 12632004: Revert 186643 - Caused a 10% regression on SunSpider benchmark (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/sync_file_system_custom_bindings.h" 5 #include "chrome/renderer/extensions/sync_file_system_custom_bindings.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "chrome/common/extensions/extension_constants.h" 9 #include "chrome/common/extensions/extension_constants.h"
10 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h" 10 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
11 #include "v8/include/v8.h" 11 #include "v8/include/v8.h"
12 #include "webkit/fileapi/file_system_util.h" 12 #include "webkit/fileapi/file_system_util.h"
13 13
14 namespace extensions { 14 namespace extensions {
15 15
16 SyncFileSystemCustomBindings::SyncFileSystemCustomBindings( 16 SyncFileSystemCustomBindings::SyncFileSystemCustomBindings()
17 Dispatcher* dispatcher, v8::Handle<v8::Context> v8_context) 17 : ChromeV8Extension(NULL) {
18 : ChromeV8Extension(dispatcher, v8_context) {
19 RouteFunction( 18 RouteFunction(
20 "GetSyncFileSystemObject", 19 "GetSyncFileSystemObject",
21 base::Bind(&SyncFileSystemCustomBindings::GetSyncFileSystemObject, 20 base::Bind(&SyncFileSystemCustomBindings::GetSyncFileSystemObject,
22 base::Unretained(this))); 21 base::Unretained(this)));
23 } 22 }
24 23
25 v8::Handle<v8::Value> SyncFileSystemCustomBindings::GetSyncFileSystemObject( 24 v8::Handle<v8::Value> SyncFileSystemCustomBindings::GetSyncFileSystemObject(
26 const v8::Arguments& args) { 25 const v8::Arguments& args) {
27 if (args.Length() != 2) { 26 if (args.Length() != 2) {
28 NOTREACHED(); 27 NOTREACHED();
(...skipping 12 matching lines...) Expand all
41 if (name.empty()) { 40 if (name.empty()) {
42 NOTREACHED(); 41 NOTREACHED();
43 return v8::Undefined(); 42 return v8::Undefined();
44 } 43 }
45 std::string root_url(*v8::String::Utf8Value(args[1])); 44 std::string root_url(*v8::String::Utf8Value(args[1]));
46 if (root_url.empty()) { 45 if (root_url.empty()) {
47 NOTREACHED(); 46 NOTREACHED();
48 return v8::Undefined(); 47 return v8::Undefined();
49 } 48 }
50 49
51 WebKit::WebFrame* webframe = 50 WebKit::WebFrame* webframe = WebKit::WebFrame::frameForCurrentContext();
52 WebKit::WebFrame::frameForContext(v8_context());
53 return webframe->createFileSystem(WebKit::WebFileSystem::TypeExternal, 51 return webframe->createFileSystem(WebKit::WebFileSystem::TypeExternal,
54 WebKit::WebString::fromUTF8(name), 52 WebKit::WebString::fromUTF8(name),
55 WebKit::WebString::fromUTF8(root_url)); 53 WebKit::WebString::fromUTF8(root_url));
56 } 54 }
57 55
58 } // namespace extensions 56 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/sync_file_system_custom_bindings.h ('k') | chrome/renderer/extensions/tabs_custom_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698