Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: chrome/renderer/extensions/send_request_natives.cc

Issue 12632004: Revert 186643 - Caused a 10% regression on SunSpider benchmark (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/send_request_natives.h" 5 #include "chrome/renderer/extensions/send_request_natives.h"
6 6
7 #include "base/json/json_reader.h" 7 #include "base/json/json_reader.h"
8 #include "content/public/renderer/v8_value_converter.h" 8 #include "content/public/renderer/v8_value_converter.h"
9 #include "chrome/renderer/extensions/request_sender.h" 9 #include "chrome/renderer/extensions/request_sender.h"
10 10
11 using content::V8ValueConverter; 11 using content::V8ValueConverter;
12 12
13 namespace extensions { 13 namespace extensions {
14 14
15 SendRequestNatives::SendRequestNatives(Dispatcher* dispatcher, 15 SendRequestNatives::SendRequestNatives(Dispatcher* dispatcher,
16 RequestSender* request_sender, 16 RequestSender* request_sender)
17 ChromeV8Context* context) 17 : ChromeV8Extension(dispatcher), request_sender_(request_sender) {
18 : ChromeV8Extension(dispatcher, context->v8_context()),
19 request_sender_(request_sender),
20 context_(context) {
21 RouteFunction("GetNextRequestId", 18 RouteFunction("GetNextRequestId",
22 base::Bind(&SendRequestNatives::GetNextRequestId, 19 base::Bind(&SendRequestNatives::GetNextRequestId,
23 base::Unretained(this))); 20 base::Unretained(this)));
24 RouteFunction("StartRequest", 21 RouteFunction("StartRequest",
25 base::Bind(&SendRequestNatives::StartRequest, 22 base::Bind(&SendRequestNatives::StartRequest,
26 base::Unretained(this))); 23 base::Unretained(this)));
27 RouteFunction("GetGlobal",
28 base::Bind(&SendRequestNatives::GetGlobal,
29 base::Unretained(this)));
30 } 24 }
31 25
32 v8::Handle<v8::Value> SendRequestNatives::GetNextRequestId( 26 v8::Handle<v8::Value> SendRequestNatives::GetNextRequestId(
33 const v8::Arguments& args) { 27 const v8::Arguments& args) {
34 static int next_request_id = 0; 28 static int next_request_id = 0;
35 return v8::Integer::New(next_request_id++); 29 return v8::Integer::New(next_request_id++);
36 } 30 }
37 31
38 // Starts an API request to the browser, with an optional callback. The 32 // Starts an API request to the browser, with an optional callback. The
39 // callback will be dispatched to EventBindings::HandleResponse. 33 // callback will be dispatched to EventBindings::HandleResponse.
40 v8::Handle<v8::Value> SendRequestNatives::StartRequest( 34 v8::Handle<v8::Value> SendRequestNatives::StartRequest(
41 const v8::Arguments& args) { 35 const v8::Arguments& args) {
42 std::string name = *v8::String::AsciiValue(args[0]); 36 std::string name = *v8::String::AsciiValue(args[0]);
43 int request_id = args[2]->Int32Value(); 37 int request_id = args[2]->Int32Value();
44 bool has_callback = args[3]->BooleanValue(); 38 bool has_callback = args[3]->BooleanValue();
45 bool for_io_thread = args[4]->BooleanValue(); 39 bool for_io_thread = args[4]->BooleanValue();
46 bool preserve_null_in_objects = args[5]->BooleanValue(); 40 bool preserve_null_in_objects = args[5]->BooleanValue();
47 41
48 scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create()); 42 scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
49 43
50 // See http://crbug.com/149880. The context menus APIs relies on this, but 44 // See http://crbug.com/149880. The context menus APIs relies on this, but
51 // we shouldn't really be doing it (e.g. for the sake of the storage API). 45 // we shouln't really be doing it (e.g. for the sake of the storage API).
52 converter->SetFunctionAllowed(true); 46 converter->SetFunctionAllowed(true);
53 47
54 if (!preserve_null_in_objects) 48 if (!preserve_null_in_objects)
55 converter->SetStripNullFromObjects(true); 49 converter->SetStripNullFromObjects(true);
56 50
57 scoped_ptr<Value> value_args(converter->FromV8Value(args[1], v8_context())); 51 scoped_ptr<Value> value_args(
52 converter->FromV8Value(args[1], v8::Context::GetCurrent()));
58 if (!value_args.get() || !value_args->IsType(Value::TYPE_LIST)) { 53 if (!value_args.get() || !value_args->IsType(Value::TYPE_LIST)) {
59 NOTREACHED() << "Unable to convert args passed to StartRequest"; 54 NOTREACHED() << "Unable to convert args passed to StartRequest";
60 return v8::Undefined(); 55 return v8::Undefined();
61 } 56 }
62 57
63 request_sender_->StartRequest( 58 request_sender_->StartRequest(name, request_id, has_callback, for_io_thread,
64 context_, name, request_id, has_callback, for_io_thread, 59 static_cast<ListValue*>(value_args.get()));
65 static_cast<ListValue*>(value_args.get()));
66 return v8::Undefined(); 60 return v8::Undefined();
67 } 61 }
68 62
69 v8::Handle<v8::Value> SendRequestNatives::GetGlobal(const v8::Arguments& args) {
70 CHECK_EQ(1, args.Length());
71 CHECK(args[0]->IsObject());
72 return v8::Handle<v8::Object>::Cast(args[0])->CreationContext()->Global();
73 }
74
75 } // namespace extensions 63 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/send_request_natives.h ('k') | chrome/renderer/extensions/set_icon_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698