Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: dm/DMSrcSinkAndroid.h

Issue 1263143004: Missing overrides for Sinks in HWUI. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMSrcSinkAndroid.h
diff --git a/dm/DMSrcSinkAndroid.h b/dm/DMSrcSinkAndroid.h
index bd4adcbe2433da27873586ce6e621e271ac184ad..02eb1c98c1b07a1fe4c55d4e8452e0abe3d1b316 100644
--- a/dm/DMSrcSinkAndroid.h
+++ b/dm/DMSrcSinkAndroid.h
@@ -25,6 +25,7 @@ public:
Error draw(const Src&, SkBitmap*, SkWStream*, SkString*) const override;
int enclave() const override { return kGPU_Enclave; }
const char* fileExtension() const override { return "png"; }
+ SinkFlags flags() const override { return SinkFlags{ SinkFlags::kGPU, SinkFlags::kDirect }; }
};
/*~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*/
@@ -38,6 +39,11 @@ public:
Error draw(const Src&, SkBitmap*, SkWStream*, SkString*) const override;
int enclave() const override { return fSink->enclave(); }
const char* fileExtension() const override { return fSink->fileExtension(); }
+ SinkFlags flags() const override {
+ SinkFlags flags = fSink->flags();
+ flags.approach = SinkFlags::kIndirect;
+ return flags;
+ }
private:
SkAutoTDelete<Sink> fSink;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698