Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1263143004: Missing overrides for Sinks in HWUI. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
djsollen, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Missing overrides for Sinks in HWUI. See crrev.com/1263113002 BUG=skia:4138 Committed: https://skia.googlesource.com/skia/+/f23190078b7139d63a639a8acfc21ddce183fd0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M dm/DMSrcSinkAndroid.h View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 4 months ago (2015-08-03 17:01:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263143004/1
5 years, 4 months ago (2015-08-03 17:05:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-03 17:13:40 UTC) #6
reed1
lgtm
5 years, 4 months ago (2015-08-03 17:17:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263143004/1
5 years, 4 months ago (2015-08-03 17:18:30 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 17:20:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f23190078b7139d63a639a8acfc21ddce183fd0a

Powered by Google App Engine
This is Rietveld 408576698