Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1263103003: Animations: Port ProgrammaticScrollAnimator to use compositor timelines (Closed)

Created:
5 years, 4 months ago by loyso (OOO)
Modified:
5 years, 4 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews, kenneth.christiansen, shans, rjwright, blink-reviews-animation_chromium.org, blink-layers+watch_chromium.org, darktears, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Animations: Port ProgrammaticScrollAnimator to use compositor timelines Use AnimationPlayer to add animations if new system enabled. Previous episode: https://codereview.chromium.org/1119763003/ What we want to achieve: https://codereview.chromium.org/1131833002 This is a re-land of https://codereview.chromium.org/1133513002 The following expectations added to match those we already have for virtual/threaded/fast/scroll-behavior: 1) Skip the entire suite on Linux ASAN bots. 2) Mark the entire suite as slow. BUG=394777 R=ajuma@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200047

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Add entry ino FlakyTests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -11 lines) Patch
M LayoutTests/ASANExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/FlakyTests View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/SlowTests View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/TestExpectations View 1 2 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/VirtualTestSuites View 1 1 chunk +7 lines, -0 lines 0 comments Download
A + LayoutTests/virtual/threaded_animation_timelines/fast/scroll-behavior/README.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 4 chunks +16 lines, -1 line 0 comments Download
M Source/platform/scroll/ProgrammaticScrollAnimator.h View 4 chunks +16 lines, -2 lines 0 comments Download
M Source/platform/scroll/ProgrammaticScrollAnimator.cpp View 6 chunks +78 lines, -5 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/platform/scroll/ScrollableArea.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
loyso (OOO)
5 years, 4 months ago (2015-08-03 01:35:01 UTC) #2
Ian Vollick
On 2015/08/03 01:35:01, loyso wrote: lgtm.
5 years, 4 months ago (2015-08-05 13:22:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263103003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263103003/40001
5 years, 4 months ago (2015-08-05 13:23:05 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 14:43:18 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200047

Powered by Google App Engine
This is Rietveld 408576698