chrome/browser/ui/search/search_model_observer.h - Issue 12631008: alternate ntp: implement Show/HideBars API to reduce jank when showing/hiding bars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_model_observer.h

Issue 12631008: alternate ntp: implement Show/HideBars API to reduce jank when showing/hiding bars (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased, resolved conflicts Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/search/search_model_observer.h

diff --git a/chrome/browser/ui/search/search_model_observer.h b/chrome/browser/ui/search/search_model_observer.h

index 970bba80ca9f0d94eb5ec76d9563a95160c211bb..8b5fa0162790f23d1d660b24798291b2b8f2d245 100644

--- a/chrome/browser/ui/search/search_model_observer.h

+++ b/chrome/browser/ui/search/search_model_observer.h

@@ -13,8 +13,10 @@ struct Mode;

// This class defines the observer interface for the |SearchModel|.

class SearchModelObserver {

public:

- // Informs the observer that the mode has changed.

- virtual void ModeChanged(const Mode& old_mode, const Mode& new_mode) = 0;

+ // Informs the observer that the model has changed.

dhollowa 2013/03/13 17:21:55 "... the model's state has changed."

kuan 2013/03/13 22:21:07 Done.

+ virtual void ModelChanged(const Mode& old_mode,

dhollowa 2013/03/13 17:21:55 As mentioned: virtual void ModelChanged(const Sear

kuan 2013/03/13 22:21:07 Done.

+ const Mode& new_mode,

+ bool top_bars_visible) = 0;

protected:

virtual ~SearchModelObserver() {}

« chrome/browser/ui/search/search_model.cc ('K') | « chrome/browser/ui/search/search_model.cc ('k') | chrome/browser/ui/search/search_tab_helper.h » ('j') | no next file with comments »