chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 12631008: alternate ntp: implement Show/HideBars API to reduce jank when showing/hiding bars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 12631008: alternate ntp: implement Show/HideBars API to reduce jank when showing/hiding bars (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixed build break Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.h ('k') | chrome/browser/ui/cocoa/tab_contents/instant_overlay_controller_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index 6a0f839fc1f1f628e363de2bd0ce6800ee0bfde7..2dd1dbc8abb44310dfe0c2bdab586d3e4d591c6d 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -665,9 +665,9 @@ extensions::ActiveTabPermissionGranter*

return tab_helper ? tab_helper->active_tab_permission_granter() : NULL;

}

-void BrowserWindowCocoa::ModeChanged(

- const chrome::search::Mode& old_mode,

- const chrome::search::Mode& new_mode) {

+void BrowserWindowCocoa::ModelChanged(

+ const chrome::search::SearchModel::State& old_state,

+ const chrome::search::SearchModel::State& new_state) {

[controller_ updateBookmarkBarStateForInstantOverlay];

}