Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: chrome/renderer/searchbox/searchbox.cc

Issue 12631008: alternate ntp: implement Show/HideBars API to reduce jank when showing/hiding bars (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/searchbox/searchbox.cc
diff --git a/chrome/renderer/searchbox/searchbox.cc b/chrome/renderer/searchbox/searchbox.cc
index 59163ee0739287a2d7528451536f5c4592cf0d3d..c3bb568330caadca69a00387ec8e711014154377 100644
--- a/chrome/renderer/searchbox/searchbox.cc
+++ b/chrome/renderer/searchbox/searchbox.cc
@@ -101,6 +101,18 @@ void SearchBox::UndoAllMostVisitedDeletions() {
render_view()->GetRoutingID()));
}
+void SearchBox::ShowBars() {
+ DVLOG(1) << render_view() << " ShowBars";
+ render_view()->Send(new ChromeViewHostMsg_SearchBoxShowBars(
+ render_view()->GetRoutingID(), render_view()->GetPageId()));
+}
+
+void SearchBox::HideBars() {
+ DVLOG(1) << render_view() << " HideBars";
+ render_view()->Send(new ChromeViewHostMsg_SearchBoxHideBars(
+ render_view()->GetRoutingID(), render_view()->GetPageId()));
+}
+
int SearchBox::GetStartMargin() const {
return static_cast<int>(start_margin_ / GetZoom());
}
@@ -143,6 +155,7 @@ bool SearchBox::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxCancel, OnCancel)
IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxPopupResize, OnPopupResize)
IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxMarginChange, OnMarginChange)
+ IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxBarsHidden, OnBarsHidden)
dhollowa 2013/03/08 00:03:32 The lack of symmetry here seems a bit strange...
kuan 2013/03/12 18:00:38 it doesn't seem to be needed, at least not yet :)
IPC_MESSAGE_HANDLER(ChromeViewMsg_DetermineIfPageSupportsInstant,
OnDetermineIfPageSupportsInstant)
IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxAutocompleteResults,
@@ -233,6 +246,13 @@ void SearchBox::OnMarginChange(int margin, int width) {
}
}
+void SearchBox::OnBarsHidden() {
+ if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {
+ extensions_v8::SearchBoxExtension::DispatchBarsHidden(
+ render_view()->GetWebView()->mainFrame());
+ }
+}
+
void SearchBox::OnDetermineIfPageSupportsInstant() {
if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {
bool result = extensions_v8::SearchBoxExtension::PageSupportsInstant(

Powered by Google App Engine
This is Rietveld 408576698