alternate ntp: implement Show/HideBars API to reduce jank when showing/hiding bars

chrome/browser/ui/search/search_model.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_SEARCH_SEARCH_MODEL_H_
 #define CHROME_BROWSER_UI_SEARCH_SEARCH_MODEL_H_
 
 #include "base/basictypes.h"
 #include "base/observer_list.h"
 #include "chrome/common/search_types.h"
 
 namespace chrome {
 namespace search {
 
 class SearchModelObserver;
 
 // An observable model for UI components that care about search model state
 // changes.
 class SearchModel {
  public:
+  struct State {
+    State() : top_bars_visible(true) {}
+
+    bool operator==(const State& rhs) const {
+      return mode == rhs.mode && top_bars_visible == rhs.top_bars_visible;
+    }
+
+    // The display mode of UI elements such as the toolbar, the tab strip, etc.
+    Mode mode;
+    // The visibility of top bars (bookmark and info bars).

[dhollowa, 2013/03/14 00:30:58]

nit: Match comment style: "The visibility of top bars such as bookmark and info
bars."

[kuan, 2013/03/14 00:44:18]

Done.

+    bool top_bars_visible;
+  };
+
   SearchModel();
   ~SearchModel();
 
-  // Change the mode.  Change notifications are sent to observers.  An animated
-  // transition may be requested.
+  // Change the state.  Change notifications are sent to observers.
+  void SetState(const State& state);
+
+  // Get the current state.
+  const State& state() const { return state_; }
+
+  // Change the mode.  Change notifications are sent to observers.
   void SetMode(const Mode& mode);
 
   // Get the active mode.
-  const Mode& mode() const { return mode_; }
+  const Mode& mode() const { return state_.mode; }
+
+  // Set visibility of top bars (bookmark and info bars).  Notifications are

[dhollowa, 2013/03/14 00:30:58]

You can remove the "(bookmark and info bars)" bit here.  It's redundant.

[kuan, 2013/03/14 00:44:18]

Done.

+  // sent to observers.
+  void SetTopBarsVisible(bool visible);
+
+  // Get the visibility of top bars (bookmark and info bars).

[dhollowa, 2013/03/14 00:30:58]

You can remove the "(bookmark and info bars)" bit here.  It's redundant.

[kuan, 2013/03/14 00:44:18]

Done.

+  bool top_bars_visible() const { return state_.top_bars_visible; }
 
   // Add and remove observers.
   void AddObserver(SearchModelObserver* observer);
   void RemoveObserver(SearchModelObserver* observer);
 
+  // Returns true if visibility in top bars should be changed based on
+  // |old_mode| and |new_mode|.

[dhollowa, 2013/03/14 00:30:58]

old_state, new_state

[kuan, 2013/03/14 00:44:18]

Done.

+  static bool ShouldChangeTopBarsVisibility(const State& old_state,

[dhollowa, 2013/03/14 00:30:58]

Public static methods go to top of class.

[kuan, 2013/03/14 00:44:18]

Done.

+                                            const State& new_state);
+
  private:
-  // The display mode of UI elements such as the toolbar, the tab strip, etc.
-  Mode mode_;
+  // Current state of model.
+  State state_;
 
   // Observers.
   ObserverList<SearchModelObserver> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(SearchModel);
 };
 
 }  // namespace search
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_UI_SEARCH_SEARCH_MODEL_H_