alternate ntp: implement Show/HideBars API to reduce jank when showing/hiding bars

chrome/browser/ui/search/search_model.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_SEARCH_SEARCH_MODEL_H_
 #define CHROME_BROWSER_UI_SEARCH_SEARCH_MODEL_H_
 
 #include "base/basictypes.h"
 #include "base/observer_list.h"
 #include "chrome/common/search_types.h"
 
 namespace chrome {
 namespace search {
 
 class SearchModelObserver;
 
 // An observable model for UI components that care about search model state
 // changes.
 class SearchModel {
  public:
   SearchModel();
   ~SearchModel();
 
-  // Change the mode.  Change notifications are sent to observers.  An animated
-  // transition may be requested.
+  // Change the mode.  Change notifications are sent to observers.
   void SetMode(const Mode& mode);
 
   // Get the active mode.
   const Mode& mode() const { return mode_; }
 
+  // Set visibility of top bars (bookmark and info bars).  Notifications are
+  // sent to observers.
+  void SetTopBarsVisible(bool visible);
+
+  // Get the visibility of top bars (bookmark and info bars).
+  bool top_bars_visible() const { return top_bars_visible_; }
+
   // Add and remove observers.
   void AddObserver(SearchModelObserver* observer);
   void RemoveObserver(SearchModelObserver* observer);
 
  private:
   // The display mode of UI elements such as the toolbar, the tab strip, etc.

[dhollowa, 2013/03/13 17:21:55]

For cleanliness, let's stick this model data into a struct, like:

 public:
  struct State {
    Mode mode;
    bool top_bars_visible;
  }
 private:
  State state_;

then in SMO...

 virtual void ModelChanged(
    const SearchModel::State& old_state,
    const SearchModel::State& new_state) = 0;

[kuan, 2013/03/13 22:21:07]

Done.

   Mode mode_;
 
+  // The visibility of top bars (bookmark and info bars).
+  bool top_bars_visible_;
+
   // Observers.
   ObserverList<SearchModelObserver> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(SearchModel);
 };
 
 }  // namespace search
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_UI_SEARCH_SEARCH_MODEL_H_