Issue 1263093004: Do not use the gzipped file to compute the ETag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1263093004: Do not use the gzipped file to compute the ETag. (Closed)

Created:
5 years, 4 months ago by qsr

Modified:
5 years, 4 months ago

Reviewers:
ppi

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Do not use the gzipped file to compute the ETag. gzip is not a stable format. If the file didn't change but the gz doesn't exist, the etag would change which would force the shell to re-download the content. R=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/65ca02044f3969b24640963f57e094210ccfaa84

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	mojo/devtools/common/devtoolslib/http_server.py	View		3 chunks	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

qsr

5 years, 4 months ago (2015-08-03 11:54:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
65ca02044f3969b24640963f57e094210ccfaa84 (presubmit successful).

Expand Messages | Collapse Messages