tools/gn/target_generator.cc - Issue 1263053003: Add forward_variables_from() and target() to GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/target_generator.cc

Issue 1263053003: Add forward_variables_from() and target() to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More spelling fixes Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/target_generator.cc

diff --git a/tools/gn/target_generator.cc b/tools/gn/target_generator.cc

index 6018147d4c43512b4b5e6da1ad3b1bce0eb18255..cd633f200018d9d5bda1ed6813a7a78d88c0e47a 100644

--- a/tools/gn/target_generator.cc

+++ b/tools/gn/target_generator.cc

@@ -113,8 +113,8 @@ void TargetGenerator::GenerateTarget(Scope* scope,

Target::STATIC_LIBRARY, err);

generator.Run();

} else {

- *err = Err(function_call, "Not a known output type",

- "I am very confused.");

+ *err = Err(function_call, "Not a known target type",

+ "I am very confused by the target type \"" + output_type + "\"");

}

if (err->has_error())

« no previous file with comments | « tools/gn/scope_unittest.cc ('k') | tools/gn/test_with_scope.h » ('j') | no next file with comments »