gpu/command_buffer/service/image_factory.cc - Issue 1263043006: Implement the texture uploading of ASTC compression for WebGL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/image_factory.cc

Issue 1263043006: Implement the texture uploading of ASTC compression for WebGL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/service/gles2_cmd_decoder.cc ('K') | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/ipc/gpu_command_buffer_traits_multi.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/image_factory.cc

diff --git a/gpu/command_buffer/service/image_factory.cc b/gpu/command_buffer/service/image_factory.cc

index f940498abf7edcf6922223a7fbe208fe4141193d..6b55010c8a7a5a3bae51be5508faeb0370c4ee23 100644

--- a/gpu/command_buffer/service/image_factory.cc

+++ b/gpu/command_buffer/service/image_factory.cc

@@ -71,6 +71,8 @@ bool ImageFactory::IsGpuMemoryBufferFormatSupported(

gfx::GpuMemoryBuffer::Format format,

const gpu::Capabilities& capabilities) {

switch (format) {

+ case gfx::GpuMemoryBuffer::ASTC:

+ return capabilities.texture_format_astc;

case gfx::GpuMemoryBuffer::ATC:

case gfx::GpuMemoryBuffer::ATCIA:

return capabilities.texture_format_atc;

@@ -100,6 +102,7 @@ bool ImageFactory::IsImageSizeValidForGpuMemoryBufferFormat(

const gfx::Size& size,

gfx::GpuMemoryBuffer::Format format) {

switch (format) {

+ case gfx::GpuMemoryBuffer::ASTC:

case gfx::GpuMemoryBuffer::ATC:

case gfx::GpuMemoryBuffer::ATCIA:

case gfx::GpuMemoryBuffer::DXT1: