Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 1263043006: Implement the texture uploading of ASTC compression for WebGL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/feature_info.cc
diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc
index ad541891f1a5be31f5a68b0d5565deb80f877d4b..1561be27399f6d91e54e1f274c7d6de8673369f1 100644
--- a/gpu/command_buffer/service/feature_info.cc
+++ b/gpu/command_buffer/service/feature_info.cc
@@ -145,6 +145,7 @@ FeatureInfo::FeatureFlags::FeatureFlags()
use_arb_occlusion_query2_for_occlusion_query_boolean(false),
use_arb_occlusion_query_for_occlusion_query_boolean(false),
native_vertex_array_object(false),
+ ext_texture_format_astc(false),
ext_texture_format_atc(false),
ext_texture_format_bgra8888(false),
ext_texture_format_dxt1(false),
@@ -384,6 +385,31 @@ void FeatureInfo::InitializeFeatures() {
GL_COMPRESSED_RGBA_S3TC_DXT5_EXT);
}
+ bool have_astc = extensions.Contains("GL_OES_texture_compression_astc") ||
Ken Russell (switch to Gerrit) 2015/08/07 22:32:33 I don't think we should reference the GL_OES_textu
+ extensions.Contains("GL_KHR_texture_compression_astc_ldr");
+ if (have_astc) {
+ feature_flags_.ext_texture_format_astc = true;
+ AddExtensionString("GL_KHR_texture_compression_astc_ldr");
+
+ GLint astc_rgba_type_max =
+ (GL_COMPRESSED_RGBA_ASTC_12x12_KHR -
+ GL_COMPRESSED_RGBA_ASTC_4x4_KHR);
+ GLint astc_srgba_type_max =
+ (GL_COMPRESSED_SRGB8_ALPHA8_ASTC_12x12_KHR -
+ GL_COMPRESSED_SRGB8_ALPHA8_ASTC_4x4_KHR);
+
+ // GL_COMPRESSED_RGBA_ASTC
+ for (GLint i = 0; i <= astc_rgba_type_max; i++) {
Ken Russell (switch to Gerrit) 2015/08/07 22:32:33 Why not just iterate from COMPRESSED_RGBA_ASTC_4x4
+ GLint format = GL_COMPRESSED_RGBA_ASTC_4x4_KHR + i;
+ validators_.compressed_texture_format.AddValue(format);
+ }
+ // GL_COMPRESSED_SRGB8_ALPHA8_ASTC
+ for (GLint i = 0; i <= astc_srgba_type_max; i++) {
+ GLint format = GL_COMPRESSED_SRGB8_ALPHA8_ASTC_4x4_KHR + i;
+ validators_.compressed_texture_format.AddValue(format);
+ }
+ }
+
bool have_atc = extensions.Contains("GL_AMD_compressed_ATC_texture") ||
extensions.Contains("GL_ATI_texture_compression_atitc");
if (have_atc) {

Powered by Google App Engine
This is Rietveld 408576698