Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1263043005: Drop [TreatNullAs=NullString] for Document.designMode (Closed)

Created:
5 years, 4 months ago by philipj_slow
Modified:
5 years, 4 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, vivekg_samsung, vivekg
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Drop [TreatNullAs=NullString] for Document.designMode Because Document::setDesignMode ignores everything except "yes" and "no" this change is not observable. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/dom/Document.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263043005/1
5 years, 4 months ago (2015-08-04 13:49:50 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-04 14:56:13 UTC) #4
philipj_slow
Trivial cleanup, PTAL.
5 years, 4 months ago (2015-08-04 15:05:49 UTC) #6
Rick Byers
lgtm
5 years, 4 months ago (2015-08-04 15:57:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263043005/1
5 years, 4 months ago (2015-08-04 18:58:33 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 19:01:36 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199988

Powered by Google App Engine
This is Rietveld 408576698