Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1263043004: Fix build error (missing cast to void*) (Closed)

Created:
5 years, 4 months ago by rossberg
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix build error (missing cast to void*) TBR=yangguo@chromium.org BUG= Committed: https://crrev.com/479e0c034736f7aab301daab190f5d8a58d20d7d Cr-Commit-Position: refs/heads/master@{#30001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
rossberg
5 years, 4 months ago (2015-08-04 13:35:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263043004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263043004/1
5 years, 4 months ago (2015-08-04 13:36:34 UTC) #3
Yang
On 2015/08/04 13:36:34, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 4 months ago (2015-08-04 13:38:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 14:23:11 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/479e0c034736f7aab301daab190f5d8a58d20d7d Cr-Commit-Position: refs/heads/master@{#30001}
5 years, 4 months ago (2015-08-04 14:24:43 UTC) #6
MTBrandyberry
On 2015/08/04 14:24:43, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 4 months ago (2015-08-04 15:17:58 UTC) #7
rossberg
5 years, 4 months ago (2015-08-04 15:25:25 UTC) #8
Message was sent while issue was closed.
On 2015/08/04 15:17:58, mtbrandyberry wrote:
> On 2015/08/04 14:24:43, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/479e0c034736f7aab301daab190f5d8a58d20d7d
> > Cr-Commit-Position: refs/heads/master@{#30001}
> 
> Another instance of this same issue exists on line 916 in Scope::Print(int n)
as
> well.

Oops, thanks! Fixed here:

https://codereview.chromium.org/1264233005/

Powered by Google App Engine
This is Rietveld 408576698