Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html

Issue 1263043003: Add NotificationAction.action member (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@actions
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html
diff --git a/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html
index a2c050aa31df988e774a9e77a12d40de73106d42..94fb6d8a549b703d98f9f038506d00ec571feb3a 100644
--- a/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html
+++ b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html
@@ -22,7 +22,23 @@
assert_inherits(workerInfo.registration, 'showNotification', 'showNotification() must be exposed.');
workerInfo.registration.showNotification('Title', {
- actions: [{}]
+ actions: [{ title: "Foo" }]
+ }).then(unreached_fulfillment(test)).catch(function(error) {
+ assert_equals(error.name, 'TypeError');
+ assert_equals(error.message, "Failed to execute 'showNotification' on 'ServiceWorkerRegistration': required member action is undefined.");
+ test.done();
+ });
+ }).catch(unreached_rejection(test));
+
+ }, 'showNotification() must reject if a NotificationAction has no action.');
+
+ async_test(function(test) {
+
+ getActiveServiceWorkerWithMessagePort(test, script, scope).then(function(workerInfo) {
+ assert_inherits(workerInfo.registration, 'showNotification', 'showNotification() must be exposed.');
+
+ workerInfo.registration.showNotification('Title', {
+ actions: [{ action: "foo" }]
}).then(unreached_fulfillment(test)).catch(function(error) {
assert_equals(error.name, 'TypeError');
assert_equals(error.message, "Failed to execute 'showNotification' on 'ServiceWorkerRegistration': required member title is undefined.");
@@ -30,7 +46,23 @@
});
}).catch(unreached_rejection(test));
- }, 'showNotification() must reject if an action has no title.');
+ }, 'showNotification() must reject if a NotificationAction has no title.');
+
+ async_test(function(test) {
+
+ getActiveServiceWorkerWithMessagePort(test, script, scope).then(function(workerInfo) {
+ assert_inherits(workerInfo.registration, 'showNotification', 'showNotification() must be exposed.');
+
+ workerInfo.registration.showNotification('Title', {
+ actions: [{ action: "", title: "Foo" }]
+ }).then(unreached_fulfillment(test)).catch(function(error) {
+ assert_equals(error.name, 'TypeError');
+ assert_equals(error.message, 'NotificationAction action must not be empty.');
+ test.done();
+ });
+ }).catch(unreached_rejection(test));
+
+ }, 'showNotification() must reject if a NotificationAction has an empty action.');
async_test(function(test) {
var scope = 'resources/scope/' + location.pathname + "/emptytitle";
@@ -39,15 +71,15 @@
assert_inherits(workerInfo.registration, 'showNotification', 'showNotification() must be exposed.');
workerInfo.registration.showNotification('Title', {
- actions: [{title: ""}]
+ actions: [{ action: "foo", title: "" }]
}).then(unreached_fulfillment(test)).catch(function(error) {
assert_equals(error.name, 'TypeError');
- assert_equals(error.message, 'Notification action titles must not be empty.');
+ assert_equals(error.message, 'NotificationAction title must not be empty.');
test.done();
});
}).catch(unreached_rejection(test));
- }, 'showNotification() must reject if an action has an empty title.');
+ }, 'showNotification() must reject if a NotificationAction has an empty title.');
</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698