Source/modules/notifications/Notification.idl - Issue 1263043002: Add NotificationOptions.actions so websites can provide buttons (blink)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/Notification.idl

Issue 1263043002: Add NotificationOptions.actions so websites can provide buttons (blink) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Tweak SW test Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/notifications/Notification.cpp ('K') | « Source/modules/notifications/Notification.cpp ('k') | Source/modules/notifications/NotificationAction.idl » ('j') | Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/notifications/Notification.idl

diff --git a/Source/modules/notifications/Notification.idl b/Source/modules/notifications/Notification.idl

index e4523ad835e66d8d1245d5bbd28b8db7ad2694c1..c686fd2da6fed95e814daf044550d2c8d8d7dccd 100644

--- a/Source/modules/notifications/Notification.idl

+++ b/Source/modules/notifications/Notification.idl

@@ -62,5 +62,8 @@

readonly attribute boolean silent;

[CallWith=ScriptState] readonly attribute any data;

+ // TODO(johnme): The spec uses a FrozenArray, but sequence seems to behave like one already. Investigate why.

Peter Beverloo 2015/07/31 15:38:49 Please refer to an Issue #. Figuring this out is a

johnme 2015/07/31 16:08:52 Done.

+ [RuntimeEnabled=NotificationExperimental] readonly attribute sequence<NotificationAction> actions;

[MeasureAs=NotificationClosed] void close();

};