Chromium Code Reviews Chromium Code Reviews
Issue 1263043002:
Add NotificationOptions.actions so websites can provide buttons (blink) (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html |
| diff --git a/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..eaacdb5830c94542c9baeb583c787491d735d139 |
| --- /dev/null |
| +++ b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html |
| @@ -0,0 +1,50 @@ |
| +<!doctype html> |
| +<html> |
| + <head> |
| + <title>Notifications: Check that showNotifications rejects if actions is set incorrectly.</title> |
| + <script src="../resources/testharness.js"></script> |
| + <script src="../resources/testharnessreport.js"></script> |
| + <script src="../serviceworker/resources/test-helpers.js"></script> |
| + <script src="resources/test-helpers.js"></script> |
| + </head> |
| + <body> |
| + <script> |
| + var scope = 'resources/scope/' + location.pathname, |
|
Peter Beverloo
2015/07/30 16:24:07
Could you add a description, and scope |scope|/|sc
johnme
2015/07/31 16:08:51
Done.
|
| + script = 'resources/instrumentation-service-worker.js'; |
| + |
| + testRunner.setPermission('notifications', 'granted', location.origin, location.origin); |
| + |
| + async_test(function(test) { |
| + |
| + getActiveServiceWorkerWithMessagePort(test, script, scope).then(function(workerInfo) { |
| + assert_inherits(workerInfo.registration, 'showNotification', 'showNotification() must be exposed.'); |
| + |
| + workerInfo.registration.showNotification('Title', { |
| + actions: [{}] |
| + }).then(unreached_fulfillment(test)).catch(function(error) { |
| + assert_equals(error.name, 'TypeError'); |
| + assert_equals(error.message, "Failed to execute 'showNotification' on 'ServiceWorkerRegistration': required member title is undefined."); |
| + test.done(); |
| + }); |
| + }).catch(unreached_rejection(test)); |
| + |
| + }, 'showNotification() must reject if an action has no title.'); |
| + |
| + async_test(function(test) { |
| + |
| + getActiveServiceWorkerWithMessagePort(test, script, scope).then(function(workerInfo) { |
| + assert_inherits(workerInfo.registration, 'showNotification', 'showNotification() must be exposed.'); |
| + |
| + workerInfo.registration.showNotification('Title', { |
| + actions: [{title: ""}] |
| + }).then(unreached_fulfillment(test)).catch(function(error) { |
| + assert_equals(error.name, 'TypeError'); |
| + assert_equals(error.message, 'Notification action titles must not be empty.'); |
| + test.done(); |
| + }); |
| + }).catch(unreached_rejection(test)); |
| + |
| + }, 'showNotification() must reject if an action has an empty title.'); |
| + </script> |
| + </body> |
| +</html> |
