Add NotificationOptions.actions so websites can provide buttons (blink)

Source/modules/notifications/Notification.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 74 matching lines @@
         return nullptr;
     }
 
     RefPtr<SerializedScriptValue> data;
     if (options.hasData()) {
         data = SerializedScriptValueFactory::instance().create(options.data().isolate(), options.data(), nullptr, exceptionState);
         if (exceptionState.hadException())
             return nullptr;
     }
 
+    for (NotificationAction action : options.actions()) {
+        if (action.title().isEmpty()) {
+            exceptionState.throwTypeError("Notification action titles must not be empty.");
+            return nullptr;
+        }
+    }
+
     Notification* notification = new Notification(title, context);
 
     notification->setBody(options.body());
     notification->setTag(options.tag());
     notification->setLang(options.lang());
     notification->setDir(options.dir());
     notification->setVibrate(NavigatorVibration::sanitizeVibrationPattern(options.vibrate()));
     notification->setSilent(options.silent());
     notification->setSerializedData(data.release());
     if (options.hasIcon()) {
         KURL iconUrl = options.icon().isEmpty() ? KURL() : context->completeURL(options.icon());
         if (!iconUrl.isEmpty() && iconUrl.isValid())
             notification->setIconUrl(iconUrl);
     }
+    notification->m_actions.appendRange(options.actions().begin(), options.actions().begin() + std::min(+maxActions, options.actions().size()));
 
     String insecureOriginMessage;
     UseCounter::Feature feature = context->isPrivilegedContext(insecureOriginMessage)
         ? UseCounter::NotificationSecureOrigin
         : UseCounter::NotificationInsecureOrigin;
     UseCounter::count(context, feature);
 
     notification->scheduleShow();
     notification->suspendIfNeeded();
     return notification;
 }
 
 Notification* Notification::create(ExecutionContext* context, int64_t persistentId, const WebNotificationData& data)
 {
     Notification* notification = new Notification(data.title, context);
 
     notification->setPersistentId(persistentId);
     notification->setDir(data.direction == WebNotificationData::DirectionLeftToRight ? "ltr" : "rtl");
     notification->setLang(data.lang);
     notification->setBody(data.body);
     notification->setTag(data.tag);
     notification->setSilent(data.silent);
 
     if (!data.icon.isEmpty())
         notification->setIconUrl(data.icon);
 
-    if (!data.vibrate.isEmpty()) {
-        NavigatorVibration::VibrationPattern pattern;
-        pattern.appendRange(data.vibrate.begin(), data.vibrate.end());
-        notification->setVibrate(pattern);
-    }
+    if (!data.vibrate.isEmpty())
+        notification->m_vibrate.appendRange(data.vibrate.begin(), data.vibrate.end());

[Peter Beverloo, 2015/07/30 16:24:07]

Please don't do this. Everything uses setters and here you access the property
directly. (Consistency)

We need to change this entirely - gone with the setters altogether by doing this
*in* the instance rather than in the ::create() method. Refactorings are due
that will address this, but we shouldn't break consistency until we do.

[johnme, 2015/07/31 15:10:10]

Done.

 
     const WebVector<char>& dataBytes = data.data;
     if (!dataBytes.isEmpty()) {
         notification->setSerializedData(SerializedScriptValueFactory::instance().createFromWireBytes(dataBytes.data(), dataBytes.size()));
         notification->serializedData()->registerMemoryAllocatedWithCurrentScriptContext();
     }
 
+    webActionsToActions(data.actions, notification->m_actions);

[Peter Beverloo, 2015/07/30 16:24:07]

Dito.

[johnme, 2015/07/31 15:10:10]

Done.

+
     notification->setState(NotificationStateShowing);
     notification->suspendIfNeeded();
     return notification;
 }
 
 Notification::Notification(const String& title, ExecutionContext* context)
     : ActiveDOMObject(context)
     , m_title(title)
     , m_dir("auto")
     , m_silent(false)
@@ skipping 27 matching lines @@
     SecurityOrigin* origin = executionContext()->securityOrigin();
     ASSERT(origin);
 
     // FIXME: Do CSP checks on the associated notification icon.
     WebNotificationData::Direction dir = m_dir == "rtl" ? WebNotificationData::DirectionRightToLeft : WebNotificationData::DirectionLeftToRight;
 
     // The lifetime and availability of non-persistent notifications is tied to the page
     // they were created by, and thus the data doesn't have to be known to the embedder.
     Vector<char> emptyDataWireBytes;
 
-    WebNotificationData notificationData(m_title, dir, m_lang, m_body, m_tag, m_iconUrl, m_vibrate, m_silent, emptyDataWireBytes);
+    WebVector<WebNotificationAction> webActions;
+    actionsToWebActions(m_actions, webActions);
+
+    WebNotificationData notificationData(m_title, dir, m_lang, m_body, m_tag, m_iconUrl, m_vibrate, m_silent, emptyDataWireBytes, webActions);
     notificationManager()->show(WebSecurityOrigin(origin), notificationData, this);
 
     m_state = NotificationStateShowing;
 }
 
 void Notification::close()
 {
     if (m_state != NotificationStateShowing)
         return;
 
@@ skipping 34 matching lines @@
 {
     // The notification will be showing when the user initiated the close, or it will be
     // closing if the developer initiated the close.
     if (m_state != NotificationStateShowing && m_state != NotificationStateClosing)
         return;
 
     m_state = NotificationStateClosed;
     dispatchEvent(Event::create(EventTypeNames::close));
 }
 
-NavigatorVibration::VibrationPattern Notification::vibrate(bool& isNull) const
+const NavigatorVibration::VibrationPattern& Notification::vibrate(bool& isNull) const
 {
     isNull = m_vibrate.isEmpty();
     return m_vibrate;
 }
 
 TextDirection Notification::direction() const
 {
     // FIXME: Resolve dir()=="auto" against the document.
     return dir() == "rtl" ? RTL : LTR;
 }
@@ skipping 27 matching lines @@
 }
 
 void Notification::requestPermission(ExecutionContext* context, NotificationPermissionCallback* callback)
 {
     // FIXME: Assert that this code-path will only be reached for Document environments
     // when Blink supports [Exposed] annotations on class members in IDL definitions.
     if (NotificationPermissionClient* permissionClient = NotificationPermissionClient::from(context))
         permissionClient->requestPermission(context, callback);
 }
 
+void Notification::webActionsToActions(const WebVector<WebNotificationAction>& webActions, Vector<NotificationAction>& actions)
+{
+    actions.clear();
+    actions.grow(webActions.size());
+    for (size_t i = 0; i < webActions.size(); ++i) {
+        actions[i].setTitle(webActions[i].title);
+    }
+}
+
 bool Notification::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event)
 {
     ASSERT(executionContext()->isContextThread());
     return EventTarget::dispatchEventInternal(event);
 }
 
 const AtomicString& Notification::interfaceName() const
 {
     return EventTargetNames::Notification;
 }
@@ skipping 20 matching lines @@
     return ScriptValue(scriptState, m_serializedData->deserialize(scriptState->isolate()));
 }
 
 DEFINE_TRACE(Notification)
 {
     RefCountedGarbageCollectedEventTargetWithInlineData<Notification>::trace(visitor);
     ActiveDOMObject::trace(visitor);
 }
 
 } // namespace blink