Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1263033004: [turbofan] Various fixes to allow unboxed doubles as arguments in registers and on the stack. (Closed)

Created:
5 years, 4 months ago by titzer
Modified:
5 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Various fixes to allow unboxed doubles as arguments in registers and on the stack. R=jarin@chromium.org BUG= Committed: https://crrev.com/71409be5395f867bbca0f6998bf6caa175cd8192 Cr-Commit-Position: refs/heads/master@{#30091}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add specific tests for native calling conventions. #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+782 lines, -136 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 2 4 chunks +7 lines, -13 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 4 chunks +8 lines, -13 lines 0 comments Download
M src/compiler/frame.h View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 2 chunks +9 lines, -14 lines 0 comments Download
M src/compiler/linkage.h View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/linkage.cc View 1 2 3 4 4 chunks +5 lines, -7 lines 0 comments Download
M src/compiler/machine-type.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 4 chunks +9 lines, -12 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 4 chunks +9 lines, -12 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 2 3 chunks +6 lines, -12 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 1 chunk +8 lines, -5 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 3 3 chunks +13 lines, -14 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 2 3 chunks +10 lines, -16 lines 0 comments Download
M test/cctest/cctest.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/c-signature.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/compiler/call-tester.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 1 2 3 4 3 chunks +7 lines, -6 lines 0 comments Download
A test/cctest/compiler/test-run-native-calls.cc View 1 2 3 4 5 6 1 chunk +634 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
titzer
PTAL, not yet ported to other architectures. I need to write some tests with manually ...
5 years, 4 months ago (2015-08-03 10:23:24 UTC) #1
Jarin
Looking good so far. https://codereview.chromium.org/1263033004/diff/1/src/compiler/x64/code-generator-x64.cc File src/compiler/x64/code-generator-x64.cc (right): https://codereview.chromium.org/1263033004/diff/1/src/compiler/x64/code-generator-x64.cc#newcode1224 src/compiler/x64/code-generator-x64.cc:1224: __ subq(rsp, Immediate(8)); Maybe replace ...
5 years, 4 months ago (2015-08-03 10:38:18 UTC) #2
titzer
On 2015/08/03 10:38:18, Jarin wrote: > Looking good so far. > > https://codereview.chromium.org/1263033004/diff/1/src/compiler/x64/code-generator-x64.cc > File ...
5 years, 4 months ago (2015-08-05 18:55:45 UTC) #3
Jarin
lgtm https://codereview.chromium.org/1263033004/diff/60001/src/compiler/raw-machine-assembler.h File src/compiler/raw-machine-assembler.h (right): https://codereview.chromium.org/1263033004/diff/60001/src/compiler/raw-machine-assembler.h#newcode482 src/compiler/raw-machine-assembler.h:482: // Call a given call descriptor and the ...
5 years, 4 months ago (2015-08-06 05:44:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263033004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263033004/120001
5 years, 4 months ago (2015-08-10 13:50:35 UTC) #7
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 4 months ago (2015-08-10 14:14:27 UTC) #8
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/71409be5395f867bbca0f6998bf6caa175cd8192 Cr-Commit-Position: refs/heads/master@{#30091}
5 years, 4 months ago (2015-08-10 14:14:48 UTC) #9
Yang
5 years, 4 months ago (2015-08-11 06:48:04 UTC) #10
Message was sent while issue was closed. 
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1284853002/ by yangguo@chromium.org.

The reason for reverting is: This CL breaks MIPS (roll blocker).

https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20mipsel%20-%2....

Powered by Google App Engine
This is Rietveld 408576698