Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1263003002: Cleanup webaudio related header inclusions in HTMLMediaElement (Closed)

Created:
5 years, 4 months ago by Srirama
Modified:
5 years, 4 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, mlamouri+watch-blink_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Cleanup webaudio related header inclusions in HTMLMediaElement Cleanup and remove redundant webaudio related header inclusions in HTMLMediaElement Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199806

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M Source/core/html/HTMLMediaElement.h View 2 chunks +6 lines, -3 lines 3 comments Download
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Srirama
Small cleanup. PTAL.
5 years, 4 months ago (2015-07-31 06:24:59 UTC) #2
ddorwin
drive-by: The first line of the description is duplicated.
5 years, 4 months ago (2015-07-31 06:26:28 UTC) #3
Srirama
On 2015/07/31 06:26:28, ddorwin wrote: > drive-by: The first line of the description is duplicated. ...
5 years, 4 months ago (2015-07-31 06:44:38 UTC) #4
philipj_slow
https://codereview.chromium.org/1263003002/diff/1/Source/core/html/HTMLMediaElement.h File Source/core/html/HTMLMediaElement.h (right): https://codereview.chromium.org/1263003002/diff/1/Source/core/html/HTMLMediaElement.h#newcode52 Source/core/html/HTMLMediaElement.h:52: class WebAudioSourceProvider; This wasn't here before, why is it ...
5 years, 4 months ago (2015-07-31 07:33:40 UTC) #5
Srirama
https://codereview.chromium.org/1263003002/diff/1/Source/core/html/HTMLMediaElement.h File Source/core/html/HTMLMediaElement.h (right): https://codereview.chromium.org/1263003002/diff/1/Source/core/html/HTMLMediaElement.h#newcode52 Source/core/html/HTMLMediaElement.h:52: class WebAudioSourceProvider; On 2015/07/31 07:33:40, philipj wrote: > This ...
5 years, 4 months ago (2015-07-31 07:38:49 UTC) #6
philipj_slow
lgtm https://codereview.chromium.org/1263003002/diff/1/Source/core/html/HTMLMediaElement.h File Source/core/html/HTMLMediaElement.h (right): https://codereview.chromium.org/1263003002/diff/1/Source/core/html/HTMLMediaElement.h#newcode52 Source/core/html/HTMLMediaElement.h:52: class WebAudioSourceProvider; On 2015/07/31 07:38:49, Srirama wrote: > ...
5 years, 4 months ago (2015-07-31 08:46:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263003002/1
5 years, 4 months ago (2015-07-31 08:47:24 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 08:50:56 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199806

Powered by Google App Engine
This is Rietveld 408576698