Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1262943002: Move ServiceWorker public headers to public/{web,platform}/modules/serviceworker (1/3) (Closed)

Created:
5 years, 4 months ago by kinuko
Modified:
5 years, 4 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move ServiceWorker public headers to public/{web,platform}/modules/serviceworker (1/3) Three-sided patch: [1] (blink) THIS PATCH [2] (chromium) https://codereview.chromium.org/1254023006/ [3] (blink) https://codereview.chromium.org/1262603004/ BUG=453032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200244

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebased #

Patch Set 5 : rebased 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -950 lines) Patch
M Source/modules/serviceworkers/RespondWithObserver.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClients.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClients.cpp View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerError.h View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerRegistration.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerRegistration.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebServiceWorkerProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/network/ResourceResponse.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebServiceWorker.h View 1 chunk +1 line, -39 lines 0 comments Download
M public/platform/WebServiceWorkerCache.h View 1 2 3 4 1 chunk +1 line, -64 lines 0 comments Download
M public/platform/WebServiceWorkerCacheError.h View 1 chunk +1 line, -15 lines 0 comments Download
M public/platform/WebServiceWorkerCacheStorage.h View 1 chunk +1 line, -42 lines 0 comments Download
M public/platform/WebServiceWorkerClientQueryOptions.h View 1 1 chunk +1 line, -21 lines 0 comments Download
M public/platform/WebServiceWorkerClientType.h View 1 chunk +1 line, -16 lines 0 comments Download
M public/platform/WebServiceWorkerClientsClaimCallbacks.h View 1 2 3 4 1 chunk +1 line, -14 lines 0 comments Download
M public/platform/WebServiceWorkerClientsInfo.h View 1 2 3 4 1 chunk +1 line, -44 lines 0 comments Download
M public/platform/WebServiceWorkerError.h View 1 chunk +1 line, -32 lines 0 comments Download
M public/platform/WebServiceWorkerEventResult.h View 1 chunk +1 line, -18 lines 0 comments Download
M public/platform/WebServiceWorkerProvider.h View 1 2 3 1 chunk +1 line, -42 lines 0 comments Download
M public/platform/WebServiceWorkerProviderClient.h View 1 chunk +1 line, -25 lines 0 comments Download
M public/platform/WebServiceWorkerProxy.h View 1 chunk +1 line, -22 lines 0 comments Download
M public/platform/WebServiceWorkerRegistration.h View 1 2 3 4 1 chunk +1 line, -42 lines 0 comments Download
M public/platform/WebServiceWorkerRegistrationProxy.h View 1 chunk +1 line, -28 lines 0 comments Download
M public/platform/WebServiceWorkerRequest.h View 1 chunk +1 line, -87 lines 0 comments Download
M public/platform/WebServiceWorkerResponse.h View 1 chunk +1 line, -88 lines 0 comments Download
M public/platform/WebServiceWorkerResponseError.h View 1 2 3 1 chunk +1 line, -23 lines 0 comments Download
M public/platform/WebServiceWorkerSkipWaitingCallbacks.h View 1 chunk +1 line, -12 lines 0 comments Download
M public/platform/WebServiceWorkerState.h View 1 chunk +1 line, -18 lines 0 comments Download
A + public/platform/modules/serviceworker/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorker.h View 1 chunk +6 lines, -6 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerCache.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerCacheError.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h View 1 chunk +1 line, -1 line 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerClientQueryOptions.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerClientType.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerClientsClaimCallbacks.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerClientsInfo.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerError.h View 1 chunk +1 line, -1 line 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerEventResult.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerProvider.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerProviderClient.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerProxy.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerRegistration.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerRegistrationProxy.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerRequest.h View 1 chunk +1 line, -1 line 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerResponse.h View 1 chunk +1 line, -1 line 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerResponseError.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerResponseType.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerSkipWaitingCallbacks.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/serviceworker/WebServiceWorkerState.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M public/web/WebServiceWorkerContextClient.h View 1 chunk +1 line, -158 lines 0 comments Download
M public/web/WebServiceWorkerContextProxy.h View 1 2 3 1 chunk +1 line, -50 lines 0 comments Download
M public/web/WebServiceWorkerNetworkProvider.h View 1 chunk +1 line, -33 lines 0 comments Download
A + public/web/modules/serviceworker/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/web/modules/serviceworker/WebServiceWorkerContextClient.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/web/modules/serviceworker/WebServiceWorkerContextProxy.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/web/modules/serviceworker/WebServiceWorkerNetworkProvider.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
kinuko
PTL
5 years, 4 months ago (2015-07-30 09:37:54 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-07-30 14:30:55 UTC) #4
falken
lgtm
5 years, 4 months ago (2015-07-31 08:30:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262943002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262943002/60001
5 years, 4 months ago (2015-08-03 07:13:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/38952) linux_blink_compile_dbg on tryserver.blink (JOB_FAILED, ...
5 years, 4 months ago (2015-08-03 07:16:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262943002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262943002/100001
5 years, 4 months ago (2015-08-10 14:48:29 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 14:51:53 UTC) #14
Message was sent while issue was closed. 
Committed patchset #5 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200244

Powered by Google App Engine
This is Rietveld 408576698