Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1262923003: cache private readback for gpu-images (Closed)

Created:
5 years, 4 months ago by reed1
Modified:
5 years, 4 months ago
Reviewers:
junov1, bsalomon, reed2
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

cache private readback for gpu-images Does not try to cache calls to readPixels at the moment: - not triggered by drawing - not clear if we want to perform any pixel transformations (that readPixels allows) on the GPU or CPU Can consider that another time. BUG=513695 Committed: https://skia.googlesource.com/skia/+/6f1216ac158e36a3a1cc805e7f899c755c5b98a2

Patch Set 1 #

Patch Set 2 : address items in #4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -7 lines) Patch
M include/core/SkPixelRef.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkBitmapCache.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkBitmapCache.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M src/core/SkPixelRef.cpp View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/image/SkImage_Gpu.h View 1 3 chunks +8 lines, -6 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 4 chunks +19 lines, -1 line 0 comments Download
M tests/ImageTest.cpp View 1 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
reed1
5 years, 4 months ago (2015-08-03 21:57:20 UTC) #2
reed2
still to do: - write unittest for new cache methods - preemptive purge from cache ...
5 years, 4 months ago (2015-08-03 23:57:41 UTC) #4
reed1
ptal
5 years, 4 months ago (2015-08-04 14:56:39 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262923003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262923003/20001
5 years, 4 months ago (2015-08-04 14:56:58 UTC) #7
bsalomon
lgtm
5 years, 4 months ago (2015-08-04 15:02:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262923003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262923003/20001
5 years, 4 months ago (2015-08-04 15:03:16 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 15:10:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6f1216ac158e36a3a1cc805e7f899c755c5b98a2

Powered by Google App Engine
This is Rietveld 408576698