content/shell/browser/layout_test/layout_test_message_filter.cc - Issue 1262893006: Enable testing NotificationEvent.action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_message_filter.cc

Issue 1262893006: Enable testing NotificationEvent.action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@click_actions

Patch Set: Tweak TestRunner gin::Argument handling Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/browser/layout_test/layout_test_message_filter.cc

diff --git a/content/shell/browser/layout_test/layout_test_message_filter.cc b/content/shell/browser/layout_test/layout_test_message_filter.cc

index a6713cab8545e2494312ac0b3225719445076fa8..7b80ac839dbb68958f67eefe7e2a85636b212801 100644

--- a/content/shell/browser/layout_test/layout_test_message_filter.cc

+++ b/content/shell/browser/layout_test/layout_test_message_filter.cc

@@ -112,11 +112,11 @@ void LayoutTestMessageFilter::OnSetDatabaseQuota(int quota) {

}

void LayoutTestMessageFilter::OnSimulateWebNotificationClick(

- const std::string& title) {

+ const std::string& title, int action_index) {

LayoutTestNotificationManager* manager =

LayoutTestContentBrowserClient::Get()->GetLayoutTestNotificationManager();

if (manager)

- manager->SimulateClick(title);

+ manager->SimulateClick(title, action_index);

}

void LayoutTestMessageFilter::OnAcceptAllCookies(bool accept) {