public/web/WebServiceWorkerContextProxy.h - Issue 1262893005: Add NotificationEvent.action property in SW events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebServiceWorkerContextProxy.h

Issue 1262893005: Add NotificationEvent.action property in SW events (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@actions3_fix

Patch Set: Address review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebServiceWorkerContextProxy.h

diff --git a/public/web/WebServiceWorkerContextProxy.h b/public/web/WebServiceWorkerContextProxy.h

index bf2e44d68eedbe17c179d24250c1fdc3587ff2f0..3a21bf16cdf5cde2e56c972450fdbda1928a0762 100644

--- a/public/web/WebServiceWorkerContextProxy.h

+++ b/public/web/WebServiceWorkerContextProxy.h

@@ -61,7 +61,9 @@ public:

virtual void dispatchMessageEvent(const WebString& message, const WebMessagePortChannelArray& channels) = 0;

+ // TODO(johnme): Remove this once callers have migrated to the method below.

virtual void dispatchNotificationClickEvent(int eventID, int64_t notificationID, const WebNotificationData&) = 0;

+ virtual void dispatchNotificationClickEvent(int eventID, int64_t notificationID, const WebNotificationData&, int actionIndex) = 0;

virtual void dispatchPushEvent(int eventID, const WebString& data) = 0;

« no previous file with comments | « public/platform/modules/notifications/WebNotificationData.h ('k') | no next file » | no next file with comments »