Source/modules/notifications/NotificationEvent.h - Issue 1262893005: Add NotificationEvent.action property in SW events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/NotificationEvent.h

Issue 1262893005: Add NotificationEvent.action property in SW events (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@actions3_fix

Patch Set: Address review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt ('k') | Source/modules/notifications/NotificationEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/notifications/NotificationEvent.h

diff --git a/Source/modules/notifications/NotificationEvent.h b/Source/modules/notifications/NotificationEvent.h

index e20c4f4db4827b1e1bd1eadd1fe7f990434d3cf7..210a943ee75632bf8ad78c969f166c0545f52dff 100644

--- a/Source/modules/notifications/NotificationEvent.h

+++ b/Source/modules/notifications/NotificationEvent.h

@@ -33,6 +33,7 @@ public:

~NotificationEvent() override;

Notification* notification() const { return m_notification.get(); }

+ String action() const { return m_action; }

const AtomicString& interfaceName() const override;

@@ -44,6 +45,7 @@ private:

NotificationEvent(const AtomicString& type, const NotificationEventInit&, WaitUntilObserver*);

PersistentWillBeMember<Notification> m_notification;

+ String m_action;

};

} // namespace blink