Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html

Issue 1262893005: Add NotificationEvent.action property in SW events (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@actions3_fix
Patch Set: Address review comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html
diff --git a/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html b/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html
index ad8f02c5f3871e58fabc955178b7a51ec872a645..2775be75cbdb7223fee60552074ea8ea70375d27 100644
--- a/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html
+++ b/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html
@@ -34,9 +34,9 @@
scalar: true },
12.15
],
- actions: [{ action: "one", title: "Action 1" },
- { action: "two", title: "Action 2" },
- { action: "three", title: "Action 3" }]
+ actions: [{ action: 'one', title: 'Action 1' },
+ { action: 'two', title: 'Action 2' },
+ { action: 'three', title: 'Action 3' }]
};
testRunner.setPermission('notifications', 'granted', location.origin, location.origin);
@@ -69,11 +69,10 @@
assert_equals(event.data.command, 'click', 'The notification was expected to be clicked.');
Object.keys(options).forEach(function(key) {
- if (key == 'actions') {
- // TODO(johnme): actions are not yet serialized properly.
- return;
- }
- assert_object_equals(event.data.notification[key], options[key], 'The ' + key + ' field must be the same.');
+ if (key == 'actions')
+ assert_object_equals(event.data.notification.actions, options.actions.slice(0, Notification.maxActions));
+ else
+ assert_object_equals(event.data.notification[key], options[key], 'The ' + key + ' field must be the same.');
});
test.done();

Powered by Google App Engine
This is Rietveld 408576698