LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js - Issue 1262893005: Add NotificationEvent.action property in SW events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

Issue 1262893005: Add NotificationEvent.action property in SW events (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@actions3_fix

Patch Set: Address review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/notifications/click-window-focus-document.html ('k') | LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-data-reflection.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

diff --git a/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js b/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

index 148df6e2898e466470d8ca4772827945bf2204e8..850f15fb229b358fc4871e9ee7ed1699f82c2c71 100644

--- a/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

+++ b/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

@@ -7,9 +7,11 @@ test(function() {

var event = new NotificationEvent('NotificationEvent');

assert_equals(event.type, 'NotificationEvent');

assert_will_be_idl_attribute(event, 'notification');

+ assert_will_be_idl_attribute(event, 'action');

assert_equals(event.cancelable, false);

assert_equals(event.bubbles, false);

assert_equals(event.notification, null);

+ assert_equals(event.action, "");

assert_inherits(event, 'waitUntil');

var eventWithInit = new NotificationEvent('NotificationEvent',