Issue 1262833007: Fix devtool documentation regarding app embedding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1262833007: Fix devtool documentation regarding app embedding (Closed)

Created:
5 years, 4 months ago by etiennej

Modified:
5 years, 4 months ago

Reviewers:
ppi

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix devtool documentation regarding app embedding R=ppi@chromium.org, ppi Committed: https://chromium.googlesource.com/external/mojo/+/c90e483a9ce3bba198bc697e2d3d4343aaaa76d1

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	mojo/devtools/common/README.md	View	1	4 chunks	+14 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ppi

sweet (lgtm) https://codereview.chromium.org/1262833007/diff/1/mojo/devtools/common/README.md File mojo/devtools/common/README.md (right): https://codereview.chromium.org/1262833007/diff/1/mojo/devtools/common/README.md#newcode32 mojo/devtools/common/README.md:32: mojo_run "APP_URL APP_ARGUMENTS" # Running an app ...

5 years, 4 months ago (2015-08-03 13:43:34 UTC) #2

etiennej

https://codereview.chromium.org/1262833007/diff/1/mojo/devtools/common/README.md File mojo/devtools/common/README.md (right): https://codereview.chromium.org/1262833007/diff/1/mojo/devtools/common/README.md#newcode32 mojo/devtools/common/README.md:32: mojo_run "APP_URL APP_ARGUMENTS" # Running an app with startup ...

5 years, 4 months ago (2015-08-03 13:46:46 UTC) #3

etiennej

5 years, 4 months ago (2015-08-03 13:47:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
c90e483a9ce3bba198bc697e2d3d4343aaaa76d1 (presubmit successful).

Expand Messages | Collapse Messages