tools/metrics/histograms/histograms.xml - Issue 1262753002: [SafeBrowsing] Send pings for Zip files that contain other archives.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1262753002: [SafeBrowsing] Send pings for Zip files that contain other archives. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/common/safe_browsing/download_protection_util.cc ('K') | « chrome/test/data/safe_browsing/download_protection/zipfile_rar_archive_no_binaries.zip ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index e16727c2aa6bed7f73d2ba3fc283b9ad22979c3b..0108fdabbdd945117251bdec18413033efff06c9 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -36792,6 +36792,18 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="SBClientDownload.ArchivedArchiveExtensions"

+ enum="SBClientDownloadCheckDownloadStats">

+ <owner>asanka@chromium.org</owner>

+ <summary>

+ Records a histogram of archive file types that were found while examining a

+ downloaded ZIP file.Each archive file type in a single ZIP file is recorded

Alexei Svitkine (slow) 2015/07/31 20:49:36 Nit: Space after .

asanka 2015/07/31 21:13:03 Done.

+ at most once. The relative incidence rate of each filetype in this histogram

+ should indicate the probability of finding that file type in a ZIP file

+ given that that ZIP file contains an archive file.

+ </summary>

+</histogram>

<histogram name="SBClientDownload.CheckDownloadStats"

enum="SBClientDownloadCheckDownloadStats">

<owner>mattm@chromium.org</owner>

@@ -67494,6 +67506,19 @@ To add a new entry, add it with any value and run test to compute valid value.

+ <int value="52" label="7Z"/>

+ <int value="53" label="XZ"/>

+ <int value="54" label="GZ"/>

+ <int value="55" label="TGZ"/>

+ <int value="56" label="BZ2"/>

+ <int value="57" label="TAR"/>

+ <int value="58" label="ARJ"/>

+ <int value="59" label="LZH"/>

+ <int value="60" label="LHA"/>

+ <int value="61" label="WIM"/>

+ <int value="62" label="Z"/>

+ <int value="63" label="LZMA"/>

+ <int value="64" label="CPIO"/>

</enum>