chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc - Issue 1262753002: [SafeBrowsing] Send pings for Zip files that contain other archives.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

Issue 1262753002: [SafeBrowsing] Send pings for Zip files that contain other archives. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | chrome/browser/safe_browsing/sandboxed_zip_analyzer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc b/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

index 76a82427e5a2bbf75c39fe40b537578234569823..ed00c9878995b3a5f1a64f60584027152d185b5d 100644

--- a/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

@@ -47,7 +47,7 @@ int64 GetEndTime(const ClientIncidentReport_DownloadDetails& details) {

bool IsBinaryDownload(const history::DownloadRow& row) {

// TODO(grt): Peek into archives to see if they contain binaries;

// http://crbug.com/386915.

- return (download_protection_util::IsBinaryFile(row.target_path) &&

+ return (download_protection_util::IsSupportedBinaryFile(row.target_path) &&

!download_protection_util::IsArchiveFile(row.target_path));

}