Refactor MarkupAccumulator::appendCharactersReplacingEntities()

Refactor MarkupAccumulator::appendCharactersReplacingEntities()

Refactor MarkupAccumulator::appendCharactersReplacingEntities() to:
- Use templating to avoid code duplication between the 8bit / 16bit cases
- Move EntityDescription struct to MarkupAccumulator.cpp as it is not used
  outside MarkupAccumulator.
- Use CString type for EntityDescription.reference member instead of String as
  we know the references are 8-bit. This avoid an unnecessary is8Bit() check in
  StringBuilder::append(const String&).

R=abarth
BUG=None

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164651

[abarth-chromium, 2014-01-07 20:30:01]

lgtm

[commit-bot: I haz the power, 2014-01-07 20:36:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/126273003/1

[commit-bot: I haz the power, 2014-01-07 21:31:43]

Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[Inactive, 2014-01-07 22:28:15]

https://codereview.chromium.org/126273003/diff/1/Source/core/editing/MarkupAc...
File Source/core/editing/MarkupAccumulator.cpp (left):

https://codereview.chromium.org/126273003/diff/1/Source/core/editing/MarkupAc...
Source/core/editing/MarkupAccumulator.cpp:51: DEFINE_STATIC_LOCAL(const String,
ampReference, ("&"));
Based on the clang error on the bots (error: declaration requires an exit-time
destructor [-Werror,-Wexit-time-destructors]), it looks like these static
variables were used so that we could use a const ref member in EntityDescription
structure, thus avoiding exit-time destruction.

It looks like I will need to introduce this back as I don't know a better way to
make clang happy.

[commit-bot: I haz the power, 2014-01-08 01:16:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/126273003/210001

[commit-bot: I haz the power, 2014-01-08 02:21:55]

Change committed as 164651