Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1262723003: Add a hashCode that delegates to JS for everything that defines == (Closed)

Created:
5 years, 4 months ago by Alan Knight
Modified:
5 years, 4 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@integration
Target Ref:
refs/heads/integration
Visibility:
Public.

Description

Add a hashCode that delegates to JS for everything that defines == BUG= R=terry@google.com Committed: https://github.com/dart-lang/sdk/commit/c242b6693ed1c7a97ca2aa6f09dc2c8c4079b0bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -3 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 166 chunks +168 lines, -2 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 5 chunks +5 lines, -0 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 35 chunks +35 lines, -0 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 4 chunks +4 lines, -0 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 34 chunks +34 lines, -0 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 5 chunks +5 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Alan Knight
5 years, 4 months ago (2015-07-28 21:43:07 UTC) #2
terry
lgtm
5 years, 4 months ago (2015-07-28 22:06:57 UTC) #3
Alan Knight
5 years, 4 months ago (2015-07-28 22:46:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c242b6693ed1c7a97ca2aa6f09dc2c8c4079b0bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698