Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1262723002: Fix the UI issue for showing output muted in ash tray after the device wakes up with hdmi output re… (Closed)

Created:
5 years, 4 months ago by jennyz
Modified:
5 years, 4 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the UI issue for showing output muted in ash tray after the device wakes up with hdmi output removed. BUG=512601 TBR=mnissler,derat, rkc Committed: https://crrev.com/c79ccda3ba8d2259370e7cc25dc62117750e6496 Cr-Commit-Position: refs/heads/master@{#340794}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -33 lines) Patch
M ash/system/audio/audio_observer.h View 1 chunk +6 lines, -1 line 0 comments Download
M ash/system/audio/tray_audio.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/audio/tray_audio.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray_notifier.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray_notifier.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/volume_controller_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/volume_controller_chromeos.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/audio/cras_audio_handler.h View 1 chunk +6 lines, -1 line 0 comments Download
M chromeos/audio/cras_audio_handler.cc View 1 3 chunks +12 lines, -5 lines 0 comments Download
M chromeos/audio/cras_audio_handler_unittest.cc View 6 chunks +66 lines, -9 lines 0 comments Download
M extensions/browser/api/audio/audio_service_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_audio_controller_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_audio_controller_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
jennyz
5 years, 4 months ago (2015-07-28 21:19:06 UTC) #2
jennyz
5 years, 4 months ago (2015-07-28 21:21:27 UTC) #3
jennyz
5 years, 4 months ago (2015-07-28 21:21:29 UTC) #4
jennyz
5 years, 4 months ago (2015-07-28 21:22:00 UTC) #5
stevenjb
lgtm w/ arg comments https://codereview.chromium.org/1262723002/diff/1/chromeos/audio/cras_audio_handler.cc File chromeos/audio/cras_audio_handler.cc (right): https://codereview.chromium.org/1262723002/diff/1/chromeos/audio/cras_audio_handler.cc#newcode375 chromeos/audio/cras_audio_handler.cc:375: OnOutputMuteChanged(output_mute_on_, false)); false /* system_adjust ...
5 years, 4 months ago (2015-07-28 21:36:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262723002/20001
5 years, 4 months ago (2015-07-28 22:10:09 UTC) #9
jennyz
https://codereview.chromium.org/1262723002/diff/1/chromeos/audio/cras_audio_handler.cc File chromeos/audio/cras_audio_handler.cc (right): https://codereview.chromium.org/1262723002/diff/1/chromeos/audio/cras_audio_handler.cc#newcode375 chromeos/audio/cras_audio_handler.cc:375: OnOutputMuteChanged(output_mute_on_, false)); On 2015/07/28 21:36:52, stevenjb wrote: > false ...
5 years, 4 months ago (2015-07-28 22:40:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-28 23:04:43 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c79ccda3ba8d2259370e7cc25dc62117750e6496 Cr-Commit-Position: refs/heads/master@{#340794}
5 years, 4 months ago (2015-07-28 23:05:35 UTC) #12
Mattias Nissler (ping if slow)
5 years, 4 months ago (2015-07-30 13:02:32 UTC) #14
Message was sent while issue was closed. 
policy LGTM - feel free to TBR trivial adjustments in consumers after API
changes in the future.

Powered by Google App Engine
This is Rietveld 408576698