Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1262703002: make tests portable by using 565 compatible colors (Closed)

Created:
5 years, 4 months ago by caryclark
Modified:
5 years, 4 months ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

make tests portable by using 565 compatible colors TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/125960152dfd7f2aba4c2239131bdf75d9ac2705

Patch Set 1 #

Patch Set 2 : fix dstreadshuffle text portable gm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -46 lines) Patch
M gm/aaclip.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/aarectmodes.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/addarc.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/bitmaprect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/blend.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bmpfilterqualityrepeat.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/colorcube.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M gm/discard.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/dstreadshuffle.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download
M gm/fatpathfill.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradients.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/hairmodes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefilterscropexpand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/imagefilterscropped.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/lighting.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/matriximagefilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/mipmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/modecolorfilters.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M gm/pathopsinverse.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/repeated_bitmap.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M gm/rrect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shallowgradient.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/simpleaaclip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/skbug1719.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/stringart.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/strokes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/tablecolorfilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262703002/1
5 years, 4 months ago (2015-07-28 20:40:06 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-28 20:48:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262703002/1
5 years, 4 months ago (2015-07-29 12:27:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/125960152dfd7f2aba4c2239131bdf75d9ac2705
5 years, 4 months ago (2015-07-29 12:27:51 UTC) #7
mtklein_C
5 years, 4 months ago (2015-08-14 14:39:09 UTC) #9
Message was sent while issue was closed. 
Why did we stop building gm/annotated_text.cpp here?

Powered by Google App Engine
This is Rietveld 408576698