Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1262693003: Roll src/tools/gyp to 6ee91ad8659871916f9aa840d42e1513befdf638. (Closed)

Created:
5 years, 4 months ago by brucedawson
Modified:
5 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/tools/gyp to 6ee91ad8659871916f9aa840d42e1513befdf638. This is mainly to avoid excessive linker parallelism: - Reduce DefaultConcurrentLinks from phys/4GB to phys/5GB. There are three gyp changes pulled in by this CL: https://chromium.googlesource.com/external/gyp/+log/5122240c..6ee91ad8 R=thakis@chromium.org BUG=440500 Committed: https://crrev.com/945d5e45f7a7a24c86e44b6259cd9658d5ce2189 Cr-Commit-Position: refs/heads/master@{#343251}

Patch Set 1 #

Patch Set 2 : Test Dan's change #

Patch Set 3 : Undo even Dan's change #

Patch Set 4 : Retrying just Dan's change #

Patch Set 5 : Resetting to the original change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (4 generated)
brucedawson
Here's a roll CL for the 4GB to 5 GB gyp change. There are three ...
5 years, 4 months ago (2015-07-29 00:10:36 UTC) #1
brucedawson
I got some more data last night which may make me want to suggest an ...
5 years, 4 months ago (2015-07-29 18:16:40 UTC) #2
Nico
lgtm I have no opinion on doing the gn change in this same CL or ...
5 years, 4 months ago (2015-07-29 18:27:10 UTC) #3
brucedawson
Here's a sample of some of the variation that I saw across 14 builds: VS ...
5 years, 4 months ago (2015-07-29 18:42:25 UTC) #4
brucedawson
Further tests showed that reducing the links did not reliably correlated with making memory worse ...
5 years, 4 months ago (2015-08-11 20:41:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262693003/1
5 years, 4 months ago (2015-08-11 20:41:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/46567)
5 years, 4 months ago (2015-08-11 21:29:58 UTC) #9
brucedawson
This change is blocked on https://codereview.chromium.org/1284423002/ and will be landed after that change lands (to ...
5 years, 4 months ago (2015-08-12 22:06:33 UTC) #10
brucedawson
After the blocking change was landed linux_android_rel_ng failed WebRtcBrowserTest.CallWithSctpDataAndMedia both with and without the patch...
5 years, 4 months ago (2015-08-13 00:25:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262693003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262693003/80001
5 years, 4 months ago (2015-08-13 17:53:15 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-08-13 19:16:36 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 19:17:19 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/945d5e45f7a7a24c86e44b6259cd9658d5ce2189
Cr-Commit-Position: refs/heads/master@{#343251}

Powered by Google App Engine
This is Rietveld 408576698