Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1262693002: test launcher: print test file names and lines in summary results (Closed)

Created:
5 years, 4 months ago by Paweł Hajdan Jr.
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

test launcher: print test file names and lines in summary results BUG=none Committed: https://crrev.com/b4cf4a09c63414336fadb41e1b3c53a9b770dd07 Cr-Commit-Position: refs/heads/master@{#340868}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -52 lines) Patch
M base/test/gtest_util.h View 3 chunks +10 lines, -4 lines 0 comments Download
M base/test/gtest_util.cc View 3 chunks +29 lines, -13 lines 0 comments Download
M base/test/launcher/test_launcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M base/test/launcher/test_launcher_ios.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/launcher/test_launcher_nacl_nonsfi.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/launcher/test_results_tracker.h View 1 4 chunks +16 lines, -1 line 0 comments Download
M base/test/launcher/test_results_tracker.cc View 3 chunks +31 lines, -21 lines 0 comments Download
M base/test/launcher/unit_test_launcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/test_launcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Paweł Hajdan Jr.
5 years, 4 months ago (2015-07-28 20:24:58 UTC) #2
sky
LGTM https://codereview.chromium.org/1262693002/diff/1/base/test/launcher/test_results_tracker.h File base/test/launcher/test_results_tracker.h (right): https://codereview.chromium.org/1262693002/diff/1/base/test/launcher/test_results_tracker.h#newcode102 base/test/launcher/test_results_tracker.h:102: CodeLocation(const std::string f, int l) : file(f), line(l) ...
5 years, 4 months ago (2015-07-28 22:37:08 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/1262693002/diff/1/base/test/launcher/test_results_tracker.h File base/test/launcher/test_results_tracker.h (right): https://codereview.chromium.org/1262693002/diff/1/base/test/launcher/test_results_tracker.h#newcode102 base/test/launcher/test_results_tracker.h:102: CodeLocation(const std::string f, int l) : file(f), line(l) { ...
5 years, 4 months ago (2015-07-29 08:47:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262693002/20001
5 years, 4 months ago (2015-07-29 08:47:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-29 09:50:04 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 09:50:53 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b4cf4a09c63414336fadb41e1b3c53a9b770dd07
Cr-Commit-Position: refs/heads/master@{#340868}

Powered by Google App Engine
This is Rietveld 408576698