Issue 1262683003: Missing bExact -> iExact conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1262683003: Missing bExact -> iExact conversions (Closed)

Created:
5 years, 4 months ago by Tom Sepez

Modified:
5 years, 4 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Missing bExact -> iExact conversions This is the cause of the mac embeddertest failure when fx_bool is replaced by bool (an incorrect overload). The types still match on master, prior to the conversion, so it's not noticed. Find other instances as well. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/452bafebc358d9a1d57266b31a5869584c0fbfb7

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	core/src/fxge/android/fx_android_font.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fxge/android/fx_android_font.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fxge/apple/fx_mac_imp.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (1 generated)

Tom Sepez

On 2015/07/28 23:26:04, Lei Zhang wrote: > lgtm > > We should get an Android ...

5 years, 4 months ago (2015-07-28 23:27:07 UTC) #4

Tom Sepez

5 years, 4 months ago (2015-07-28 23:27:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
452bafebc358d9a1d57266b31a5869584c0fbfb7 (presubmit successful).