Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8008)

Unified Diff: chromecast/tools/build/chromecast_repack_locales.py

Issue 1262673004: [Chromecast] Change chromecast_branding to public (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/media/media.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/tools/build/chromecast_repack_locales.py
diff --git a/chromecast/tools/build/chromecast_repack_locales.py b/chromecast/tools/build/chromecast_repack_locales.py
index 607930a7c2173ade06f0f2d0f77b4ca39b38e901..5639567bcd5b033dfb9f8b6f27222ea61e4060ed 100755
--- a/chromecast/tools/build/chromecast_repack_locales.py
+++ b/chromecast/tools/build/chromecast_repack_locales.py
@@ -41,7 +41,7 @@ def calc_output(locale):
def calc_inputs(locale):
"""Determine the files that need processing for the given locale."""
inputs = []
- if CHROMECAST_BRANDING == 'Chrome':
+ if CHROMECAST_BRANDING != 'public':
inputs.append(os.path.join(GRIT_DIR, 'app_strings_%s.pak' % locale))
inputs.append(os.path.join(GRIT_DIR, 'chromecast_settings_%s.pak' % locale))
return inputs
@@ -99,7 +99,7 @@ def DoMain(argv):
parser.add_option("-x", action="store", dest="int_dir",
help="Intermediate build files output directory.")
parser.add_option("-b", action="store", dest="chromecast_branding",
- help="Chromecast branding ('Chrome' or 'Chromium').")
+ help="Chromecast branding ('public', 'internal' or 'google').")
options, locales = parser.parse_args(argv)
if not locales:
@@ -111,7 +111,9 @@ def DoMain(argv):
INT_DIR = options.int_dir
CHROMECAST_BRANDING = options.chromecast_branding
- if CHROMECAST_BRANDING != "Chrome" and CHROMECAST_BRANDING != "Chromium":
+ if (CHROMECAST_BRANDING != "public" and
+ CHROMECAST_BRANDING != "internal" and
+ CHROMECAST_BRANDING != "google"):
byungchul 2015/07/29 20:20:58 prefer ' to " for string constants.
yucliu1 2015/07/29 20:34:02 Done.
parser.error('Chromecast branding (-b) must be "Chrome" or "Chromium".\n')
if not (GRIT_DIR and INT_DIR):
parser.error('Please specify all of "-g" and "-x".\n')
« no previous file with comments | « chromecast/media/media.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698