Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1262623009: Remove stale dependency in "ozone_demo" GN target. (Closed)

Created:
5 years, 4 months ago by slan
Modified:
5 years, 4 months ago
Reviewers:
jam, nasko, spang
CC:
chromium-reviews, darin-cc_chromium.org, jam, ozone-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stale dependency in "ozone_demo" GN target. The target "ui/ozone/gpu" no longer exists. Remove the dependency on it. Also remove reference to this directory in content/DEPS. To test, set use_ozone=true in gn args and perform a build of ui/ozone/demo:ozone_demo. BUG= Committed: https://crrev.com/07ea627e1310ea81313db708d044753e7507b100 Cr-Commit-Position: refs/heads/master@{#341783}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/demo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
slan
Encountered this issue while building Chromecast with GN. PTAL.
5 years, 4 months ago (2015-08-04 17:00:22 UTC) #2
spang
lgtm
5 years, 4 months ago (2015-08-04 17:00:59 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262623009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262623009/1
5 years, 4 months ago (2015-08-04 17:04:13 UTC) #5
slan
+nasko for content/DEPS
5 years, 4 months ago (2015-08-04 17:45:49 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-04 17:52:17 UTC) #9
jam
lgtm
5 years, 4 months ago (2015-08-04 20:15:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262623009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262623009/1
5 years, 4 months ago (2015-08-04 20:28:53 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 20:37:48 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 20:39:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07ea627e1310ea81313db708d044753e7507b100
Cr-Commit-Position: refs/heads/master@{#341783}

Powered by Google App Engine
This is Rietveld 408576698