tools/telemetry/telemetry/internal/util/find_dependencies.py - Issue 1262623007: Reland of Create classes_util API, change discover to return a list instead of a dict.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/util/find_dependencies.py

Issue 1262623007: Reland of Create classes_util API, change discover to return a list instead of a dict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/platform/tracing_controller_backend.py ('k') | tools/telemetry/telemetry/record_wpr.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/util/find_dependencies.py

diff --git a/tools/telemetry/telemetry/internal/util/find_dependencies.py b/tools/telemetry/telemetry/internal/util/find_dependencies.py

index 6f40196fb2faee58fc37d502635fe853e576645b..b9592449f0d75fcee7e91fcdad745a9d010a78c8 100644

--- a/tools/telemetry/telemetry/internal/util/find_dependencies.py

+++ b/tools/telemetry/telemetry/internal/util/find_dependencies.py

@@ -12,11 +12,12 @@ import sys

import zipfile

from telemetry import benchmark

-from telemetry.core import discover

from telemetry.internal.util import bootstrap

from telemetry.internal.util import command_line

from telemetry.internal.util import path

from telemetry.internal.util import path_set

+from telemetry.util import classes_util

DEPS_FILE = 'bootstrap_deps'

@@ -61,10 +62,9 @@ def FindPageSetDependencies(base_dir):

# Add base_dir to path so our imports relative to base_dir will work.

sys.path.append(base_dir)

- tests = discover.DiscoverClasses(base_dir, base_dir, benchmark.Benchmark,

- index_by_class_name=True)

+ tests = classes_util.DiscoverClasses(base_dir, base_dir, benchmark.Benchmark)

- for test_class in tests.itervalues():

+ for test_class in tests:

test_obj = test_class()

# Ensure the test's default options are set if needed.