Remove interface_impl.h and error_handler.h usage from chromium

Remove interface_impl.h and error_handler.h usage from chromium

R=yzshen@chromium.org
BUG=none

Committed: https://crrev.com/db9fe96835e12442682df6f66f2db46d208f9914
Cr-Commit-Position: refs/heads/master@{#340921}

[yzshen1, 2015-07-29 00:01:02]

https://codereview.chromium.org/1262613005/diff/1/content/browser/permissions...
File content/browser/permissions/permission_service_impl.h (left):

https://codereview.chromium.org/1262613005/diff/1/content/browser/permissions...
content/browser/permissions/permission_service_impl.h:88: void
OnConnectionError() override;
I wonder who does set_error_handler() using this class as an error handler. I
couldn't find it.

[yzshen1, 2015-07-29 00:03:08]

On 2015/07/29 00:01:02, yzshen1 wrote:
>
https://codereview.chromium.org/1262613005/diff/1/content/browser/permissions...
> File content/browser/permissions/permission_service_impl.h (left):
> 
>
https://codereview.chromium.org/1262613005/diff/1/content/browser/permissions...
> content/browser/permissions/permission_service_impl.h:88: void
> OnConnectionError() override;
> I wonder who does set_error_handler() using this class as an error handler. I
> couldn't find it.

I took a closer look. I think the author of this class forgot to
set_error_handler() for |binding_|.

[Ben Goodger (Google), 2015-07-29 00:31:23]

Aha! I was hoping some build failure in my try runs would show me, but in
this case they wouldn't.

On Tue, Jul 28, 2015 at 5:03 PM, <yzshen@chromium.org> wrote:

> On 2015/07/29 00:01:02, yzshen1 wrote:
>
>
>
https://codereview.chromium.org/1262613005/diff/1/content/browser/permissions...
>
>> File content/browser/permissions/permission_service_impl.h (left):
>>
>
>
>
>
https://codereview.chromium.org/1262613005/diff/1/content/browser/permissions...
>
>> content/browser/permissions/permission_service_impl.h:88: void
>> OnConnectionError() override;
>> I wonder who does set_error_handler() using this class as an error
>> handler. I
>> couldn't find it.
>>
>
> I took a closer look. I think the author of this class forgot to
> set_error_handler() for |binding_|.
>
> https://codereview.chromium.org/1262613005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[yzshen1, 2015-07-29 02:15:29]

LGTM

I am fine with either way: fix it in this CL; or do it separately. Thanks!

[yzshen1, 2015-07-29 02:15:31]

LGTM

I am fine with either way: fix it in this CL; or do it separately. Thanks!

[xhwang, 2015-07-29 16:14:29]

xhwang@chromium.org changed reviewers:
+ xhwang@chromium.org

[xhwang, 2015-07-29 16:14:30]

media/ LGTM, thanks for fixing this.

[Ben Goodger (Google), 2015-07-29 16:58:22]

ben@chromium.org changed reviewers:
+ mlamouri@chromium.org

[Ben Goodger (Google), 2015-07-29 16:58:22]

I added the connection error handler in the permission service.

mlamouri: fyi

[Ben Goodger (Google), 2015-07-29 16:58:28]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2015-07-29 16:58:28]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org,
xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1262613005/#ps20001
(title: ".")

[commit-bot: I haz the power, 2015-07-29 16:59:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1262613005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1262613005/20001

[commit-bot: I haz the power, 2015-07-29 18:12:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-29 18:12:59]

Patchset 2 (id:??) landed as
https://crrev.com/db9fe96835e12442682df6f66f2db46d208f9914
Cr-Commit-Position: refs/heads/master@{#340921}