Source/core/loader/DocumentThreadableLoader.h - Issue 1262593004: Prevent ThreadableLoaderClient methods from being called after failure notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/DocumentThreadableLoader.h

Issue 1262593004: Prevent ThreadableLoaderClient methods from being called after failure notification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Don't clear the resource in didFinishLoading Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/DocumentThreadableLoader.h

diff --git a/Source/core/loader/DocumentThreadableLoader.h b/Source/core/loader/DocumentThreadableLoader.h

index b5b9d9d9d53c546e69326c67511603dbf2777e1c..5a403e3504c55186d284601fb33cccea39353b1c 100644

--- a/Source/core/loader/DocumentThreadableLoader.h

+++ b/Source/core/loader/DocumentThreadableLoader.h

@@ -73,6 +73,8 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv

DocumentThreadableLoader(Document&, ThreadableLoaderClient*, BlockingBehavior, const ResourceRequest&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);

+ void clear();

// ResourceClient

void notifyFinished(Resource*) override;

// RawResourceClient

« no previous file with comments | « no previous file | Source/core/loader/DocumentThreadableLoader.cpp » ('j') | Source/core/loader/DocumentThreadableLoader.cpp » ('J')